Page MenuHomePhabricator
Create Task
Maniphest T296129

Text is shown and selected when click rapidly the sidebar icon in new Vector on Windows
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Activate new Vector
  • Click the hamburger menu icon repeatedly

What happens?:

The text "Toggle" is selected and "T" is shown.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Make sure label text is not selectableDylsssmediawiki/skins/Vectormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Lens0021 created this task.Nov 20 2021, 2:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 20 2021, 2:54 PM
Lens0021 added a project: Vector (legacy skin).Nov 20 2021, 2:56 PM
Lens0021 moved this task from Needs triage to Menus on the Vector (legacy skin) board.
Lens0021 updated the task description. (Show Details)Nov 20 2021, 2:58 PM
• nray added a project: Web-Team-Backlog-Archived.Nov 23 2021, 9:16 PM
ovasileva triaged this task as Medium priority.Dec 3 2021, 3:05 PM
ovasileva moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog-Archived board.
ovasileva added subscribers: Edtadros, ovasileva.

@Edtadros - could you take a look and try to reproduce when you get a chance?

Dylsss claimed this task.Mar 21 2022, 12:08 AM
gerritbot added a comment.Mar 21 2022, 12:10 AM

Change 772045 had a related patch set uploaded (by Dylsss; author: Dylsss):

[mediawiki/skins/Vector@master] Make sure label text is not selectable

https://gerrit.wikimedia.org/r/772045

gerritbot added a project: Patch-For-Review.Mar 21 2022, 12:10 AM
Jdlrobson removed Dylsss as the assignee of this task.Mar 21 2022, 2:59 PM
Jdlrobson assigned this task to Dylsss.
Jdlrobson edited projects, added: Web-Team-Backlog-Archived (Kanbanana-FY-2021-22); removed: Web-Team-Backlog-Archived.
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson added a subscriber: Dylsss.
Jdlrobson renamed this task from Text is shown and selected when click rapidly the sidebar icon in new Vector to Text is shown and selected when click rapidly the sidebar icon in new Vector on Windows.Mar 21 2022, 8:34 PM
Jdlrobson updated the task description. (Show Details)
PatchDemoBot added a comment.Mar 21 2022, 8:36 PM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/a729fbc506/w/

gerritbot added a comment.Mar 21 2022, 9:06 PM

Change 772045 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Make sure label text is not selectable

https://gerrit.wikimedia.org/r/772045

Maintenance_bot removed a project: Patch-For-Review.Mar 21 2022, 9:11 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.3; 2022-03-22).Mar 21 2022, 10:00 PM
Jdlrobson closed this task as Resolved.Mar 21 2022, 10:01 PM
Jdlrobson subscribed.

Can replicate on browser stack on Windows 11 Chrome 99.
Above patch fixes the problem.
Thanks @Dylsss for taking the time to write the patch!

Screen Shot 2022-03-21 at 1.50.09 PM.png (2,856×1,192 px, 724 KB)

PatchDemoBot added a comment.Aug 30 2022, 1:01 PM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/a729fbc506/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits