Page MenuHomePhabricator

Selenium Tests for VisualEditor
Open, Needs TriagePublic

Description

  • Verify that , the CE is editable 776963
  • Verify you can save the page 721024 801729 T309712
  • Automate VE Toolbar actions 844470
  • Verify you can insert/modify/remove table 841915
  • Verify you can edit/modify/remove a link 790682 790683
  • Verify you can insert/modify/remove comment 811704
  • Verify you can apply different heading style on a text
  • Very undo and redo action works properly
  • Verify you can change the effect on any text by applying different formatting options from the toolbar
  • Verify you can add all kind of citations from the "Cite" menu
  • Verify you can clear styling from a text
  • Verify you can edit/remove any existing citation
  • Check the functionality of list and indentation
  • Verify you can insert/modify/remove image
  • Verify you can insert/modify/remove template
  • Verify you can insert/modify/remove formula
  • Verify you can insert/modify/remove reference list
  • Verify the Re-use existing reference works properly
  • Verify you can insert special character
  • Verify you can add categories to the page you are editing
  • Verify you can edit different properties inside Media Settings dialog

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mediawiki/extensions/VisualEditormaster+53 -0
mediawiki/extensions/VisualEditormaster+78 -0
mediawiki/extensions/VisualEditormaster+3 -3
mediawiki/extensions/VisualEditormaster+25 -0
mediawiki/extensions/VisualEditormaster+26 -0
mediawiki/extensions/VisualEditormaster+97 -0
mediawiki/extensions/VisualEditormaster+25 -0
mediawiki/extensions/VisualEditormaster+16 -0
mediawiki/extensions/VisualEditormaster+1 -1
mediawiki/extensions/VisualEditormaster+8 -0
mediawiki/extensions/VisualEditormaster+8 -0
mediawiki/extensions/VisualEditormaster+8 -0
mediawiki/extensions/VisualEditormaster+2 -2
mediawiki/extensions/VisualEditormaster+7 -0
mediawiki/extensions/VisualEditormaster+2 -1
mediawiki/extensions/VisualEditormaster+9 -0
mediawiki/extensions/VisualEditormaster+4 -3
mediawiki/extensions/VisualEditormaster+8 -0
mediawiki/extensions/VisualEditormaster+11 -2
mediawiki/extensions/VisualEditormaster+2 -0
mediawiki/extensions/VisualEditormaster+34 -0
mediawiki/extensions/VisualEditormaster+14 -0
mediawiki/extensions/VisualEditormaster+12 -25
mediawiki/extensions/VisualEditormaster+28 -0
mediawiki/extensions/VisualEditormaster+28 -0
mediawiki/extensions/VisualEditormaster+11 -0
mediawiki/extensions/VisualEditormaster+11 -2
mediawiki/extensions/VisualEditormaster+6 -3
mediawiki/extensions/VisualEditormaster+2 -2
mediawiki/extensions/VisualEditormaster+1 -0
mediawiki/extensions/VisualEditormaster+19 -5
mediawiki/extensions/VisualEditormaster+31 -13
mediawiki/extensions/VisualEditormaster+15 -0
mediawiki/extensions/VisualEditormaster+2 -3
mediawiki/extensions/VisualEditormaster+9 -1
mediawiki/extensions/VisualEditormaster+6 -2
mediawiki/extensions/VisualEditormaster+46 -20
mediawiki/extensions/VisualEditormaster+1 -1
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 802528 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Run only one test in Jenkins daily job

https://gerrit.wikimedia.org/r/802528

Change 801729 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Better assertion after saving the page

https://gerrit.wikimedia.org/r/801729

Change 803937 had a related patch set uploaded (by Esther Akinloose; author: Esther Akinloose):

[mediawiki/extensions/VisualEditor@master] WIP selenium: saveComplete

https://gerrit.wikimedia.org/r/803937

Change 803937 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Add EditPage.saveComplete()

https://gerrit.wikimedia.org/r/803937

Change 805385 had a related patch set uploaded (by Esther Akinloose; author: Esther Akinloose):

[mediawiki/extensions/VisualEditor@master] selenium: Do not retry tests

https://gerrit.wikimedia.org/r/805385

Change 805385 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Do not retry tests

https://gerrit.wikimedia.org/r/805385

Change 790683 abandoned by Esther Akinloose:

[mediawiki/extensions/VisualEditor@master] selenium: Link icon is clickable

Reason:

https://gerrit.wikimedia.org/r/790683

Change 811704 had a related patch set uploaded (by Esther Akinloose; author: Esther Akinloose):

[mediawiki/extensions/VisualEditor@master] WIP selenium: Comment should be added

https://gerrit.wikimedia.org/r/811704

Change 790682 abandoned by Esther Akinloose:

[mediawiki/extensions/VisualEditor@master] WIP selenium: Link should be added

Reason:

https://gerrit.wikimedia.org/r/790682

Change 811704 abandoned by Esther Akinloose:

[mediawiki/extensions/VisualEditor@master] WIP selenium: Comment should be added

Reason:

Will get back to this.

https://gerrit.wikimedia.org/r/811704

Change 841128 had a related patch set uploaded (by Esther Akinloose; author: Esther Akinloose):

[mediawiki/extensions/VisualEditor@master] selenium: Move code to beforeEach and afterEach hooks

https://gerrit.wikimedia.org/r/841128

Change 841128 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Move code to beforeEach and afterEach hooks

https://gerrit.wikimedia.org/r/841128

Change 841915 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/extensions/VisualEditor@master] WIP selenium: Content editable should insert a table

https://gerrit.wikimedia.org/r/841915

Change 841915 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Content editable should insert a table

https://gerrit.wikimedia.org/r/841915

Change 844470 had a related patch set uploaded (by Esther Akinloose; author: Esther Akinloose):

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open switch editor

https://gerrit.wikimedia.org/r/844470

Change 844470 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open switch editor

https://gerrit.wikimedia.org/r/844470

Change 844855 had a related patch set uploaded (by Esther Akinloose; author: Esther Akinloose):

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open page options

https://gerrit.wikimedia.org/r/844855

Change 793478 abandoned by Zfilipin:

[mediawiki/extensions/VisualEditor@master] WIP selenium: Wait 50 seconds to see in the video recording if the page is saved

Reason:

https://gerrit.wikimedia.org/r/793478

Change 862243 had a related patch set uploaded (by Esther Akinloose; author: Esther Akinloose):

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open help popup

https://gerrit.wikimedia.org/r/862243

Change 862263 had a related patch set uploaded (by Esther Akinloose; author: Esther Akinloose):

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open notices popup as soon as it loads

https://gerrit.wikimedia.org/r/862263

Change 844855 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open page options

https://gerrit.wikimedia.org/r/844855

Change 862243 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open help popup

https://gerrit.wikimedia.org/r/862243

Change 862269 had a related patch set uploaded (by Esther Akinloose; author: Esther Akinloose):

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open special characters menu

https://gerrit.wikimedia.org/r/862269

Change 862263 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open notices popup as soon as it loads

https://gerrit.wikimedia.org/r/862263

Change 862269 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open special characters menu

https://gerrit.wikimedia.org/r/862269

Change 863400 had a related patch set uploaded (by Esther Akinloose; author: Esther Akinloose):

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open insert menu

https://gerrit.wikimedia.org/r/863400

Change 863404 had a related patch set uploaded (by Esther Akinloose; author: Esther Akinloose):

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open structure options menu

https://gerrit.wikimedia.org/r/863404

Change 863405 had a related patch set uploaded (by Esther Akinloose; author: Esther Akinloose):

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open style text options

https://gerrit.wikimedia.org/r/863405

Change 863407 had a related patch set uploaded (by Esther Akinloose; author: Esther Akinloose):

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open format paragraph menu

https://gerrit.wikimedia.org/r/863407

Change 863400 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open insert menu

https://gerrit.wikimedia.org/r/863400

Change 866581 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/extensions/VisualEditor@master] selenium: Decrease logLevel from info to error

https://gerrit.wikimedia.org/r/866581

Change 866581 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Decrease logLevel from info to error

https://gerrit.wikimedia.org/r/866581

Change 863404 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open structure options menu

https://gerrit.wikimedia.org/r/863404

Change 863405 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open style text options

https://gerrit.wikimedia.org/r/863405

Change 863407 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Toolbar should open format paragraph menu

https://gerrit.wikimedia.org/r/863407

I believe we would have caught the errors in T332415#8828832 before the patch was merged if we verified editing behavior as a logged-out user.

I think for the Temporary accounts project, anonymous editing tests will be important to have in place to catch regressions before patches get merged.

Change 931997 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/VisualEditor@master] selenium: Disable flaky test

https://gerrit.wikimedia.org/r/931997

Change 931997 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] selenium: Disable flaky test

https://gerrit.wikimedia.org/r/931997

Change 941542 had a related patch set uploaded (by Esther Akinloose; author: Esther Akinloose):

[mediawiki/extensions/VisualEditor@master] selenium: undo, redo buttons are displayed disabled

https://gerrit.wikimedia.org/r/941542

@EAkinloose: Removing task assignee as this open task has been assigned for more than two years - see the email sent to all task assignees on 2024-04-15.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Where automation might already exist
VisualEditor

Various QUnit tests are implemented. I don't fully understand what they do or how they work, so this is just my best guess.

  • Verify you can insert/modify/remove table

https://gerrit.wikimedia.org/r/plugins/gitiles/VisualEditor/VisualEditor/+/refs/heads/master/tests/ui/actions/ve.ui.TableAction.test.js

  • Verify you can edit/modify/remove a link

https://gerrit.wikimedia.org/r/plugins/gitiles/VisualEditor/VisualEditor/+/refs/heads/master/tests/ui/actions/ve.ui.LinkAction.test.js?

  • Verify you can insert/modify/remove comment

https://gerrit.wikimedia.org/r/plugins/gitiles/VisualEditor/VisualEditor/+/50edd08ba69a543c0796a213327dd6b56d85ab11/tests/ui/inspectors/ve.ui.FragmentInspector.test.js#291

  • Verify you can apply different heading style on a text

https://gerrit.wikimedia.org/r/plugins/gitiles/VisualEditor/VisualEditor/+/refs/heads/master/tests/ui/actions/ve.ui.FormatAction.test.js

  • Very undo and redo action works properly

Some of the QUnit tests already test what happens on undo, for example.

  • Verify you can change the effect on any text by applying different formatting options from the toolbar

https://gerrit.wikimedia.org/r/plugins/gitiles/VisualEditor/VisualEditor/+/refs/heads/master/tests/ui/actions/ve.ui.AnnotationAction.test.js

  • Verify you can clear styling from a text

https://gerrit.wikimedia.org/r/plugins/gitiles/VisualEditor/VisualEditor/+/50edd08ba69a543c0796a213327dd6b56d85ab11/tests/ui/actions/ve.ui.AnnotationAction.test.js#167

  • Check the functionality of list and indentation

https://gerrit.wikimedia.org/r/plugins/gitiles/VisualEditor/VisualEditor/+/refs/heads/master/tests/ui/actions/ve.ui.ListAction.test.js
https://gerrit.wikimedia.org/r/plugins/gitiles/VisualEditor/VisualEditor/+/refs/heads/master/tests/ui/actions/ve.ui.IndentationAction.test.js

  • Verify you can insert special character

https://gerrit.wikimedia.org/r/plugins/gitiles/VisualEditor/VisualEditor/+/refs/heads/master/tests/ce/imetests/?

Cite extension

Cite extension has cypress (as mentioned T296187#10272672) and qunit tests.

  • Verify you can add all kind of citations from the "Cite" menu

Unsure.

  • Verify you can edit/remove any existing citation

Editing: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Cite/+/1244b3901c0a3603770ddadf3480505d3e28cd36/tests/cypress/e2e/tests/ve-cite/veCiteIntegration.cy.js#33

  • Verify you can insert/modify/remove reference list

Viewing existing reference list: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Cite/+/1244b3901c0a3603770ddadf3480505d3e28cd36/tests/cypress/e2e/tests/ve-cite/veCiteIntegration.cy.js#50

  • Verify the Re-use existing reference works properly

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Cite/+/refs/heads/master/tests/cypress/e2e/tests/ve-cite/reuseRefs.cy.js

Other
  • Verify you can insert/modify/remove template

TemplateWizard extension has selenium and qunit tests, but I don't think these test the TemplateWizard in VisualEditor.

  • Verify you can insert/modify/remove formula

Math extension has Selenium tests, but they are very basic and don't appear to cover VisualEditor at all.

Uncertain where/if these have automation
  • Automate VE Toolbar actions
  • Verify you can insert/modify/remove image
  • Verify you can add categories to the page you are editing
  • Verify you can edit different properties inside Media Settings dialog

Change #1206926 had a related patch set uploaded (by Dom Walden; author: Dom Walden):

[mediawiki/extensions/VisualEditor@master] WIP Selenium: Inserting table

https://gerrit.wikimedia.org/r/1206926

Change #1207145 had a related patch set uploaded (by Dom Walden; author: Dom Walden):

[mediawiki/extensions/VisualEditor@master] WIP Selenium: Inserting internal link

https://gerrit.wikimedia.org/r/1207145

Change #1208279 had a related patch set uploaded (by Dom Walden; author: Dom Walden):

[mediawiki/extensions/VisualEditor@master] WIP Selenium: Inserting external link

https://gerrit.wikimedia.org/r/1208279

Change #1208283 had a related patch set uploaded (by Dom Walden; author: Dom Walden):

[mediawiki/extensions/VisualEditor@master] WIP Selenium: Inserting comment

https://gerrit.wikimedia.org/r/1208283

Change #1208295 had a related patch set uploaded (by Dom Walden; author: Dom Walden):

[mediawiki/extensions/VisualEditor@master] Selenium: Changing heading styles on text

https://gerrit.wikimedia.org/r/1208295

Change #1208308 had a related patch set uploaded (by Dom Walden; author: Dom Walden):

[mediawiki/extensions/VisualEditor@master] Selenium: Changing formatting

https://gerrit.wikimedia.org/r/1208308

Change #1208312 had a related patch set uploaded (by Dom Walden; author: Dom Walden):

[mediawiki/extensions/VisualEditor@master] Selenium: Inserting and indenting lists

https://gerrit.wikimedia.org/r/1208312