Page MenuHomePhabricator
Create Task
Maniphest T296289

swift-proxy not starting on ms-fe2009 due to missing python-monotonic
Closed, ResolvedPublic
Actions

Description

Noticed while investigating T294136, swift-proxy was failing on freshly provisioned ms-fe2009 due to missing python-monotonic (though python3-monotonic was installed). I suspect this a "recent" regression though with latest versions of swift package (and related). I've installed python-monotonic manually to verify and swift-proxy then indeed starts as expected

Details

SubjectRepoBranchLines +/-
swift: update README for rewrite middlewareoperations/puppetproduction+6 -6
swift::proxy: install python{3,}-monotonicoperations/puppetproduction+4 -0
Customize query in gerrit

Related Objects

Event Timeline

fgiunchedi created this task.Nov 23 2021, 11:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 23 2021, 11:37 AM
LSobanski subscribed.Nov 23 2021, 11:41 AM
fgiunchedi updated the task description. (Show Details)Nov 23 2021, 11:41 AM
LSobanski merged a task: T296883: ms-fe2010, ms-fe2011, ms-fe2012 had its swift-proxy.service failed.Dec 1 2021, 9:21 PM
LSobanski added subscribers: jcrespo, MatthewVernon.
jcrespo added a comment.Dec 1 2021, 9:22 PM

Ah, so I guess not in production, that leaves me less worried. Sorry, I searched for ms-fe and monotonic but couldn't find this ticket.

MatthewVernon added a comment.Dec 7 2021, 4:28 PM

OK, I know what the problem is (at least at one level). Our swift front-ends use a bit of middleware wmf.rewrite which is shipped by us from puppet; that calls import monotonic. But there's nothing to say that python-monotonic (or python3-monotonic) should be installed from swift front-ends as far as I can see.

I'm not sure what was causing python-monotonic to get installed in the past, but it might have just been luck! I'll have a look at puppetizing this.

@fgiunchedi while investigating this, I find in modules/swift/files/python3.9/SwiftMedia/README the note

The files in the wmf directory come from the svn repo for the SwiftMedia extension. That is the canonical copy; any changes here should be copied there as well.

I can only find signs of a long-deleted https://www.mediawiki.org/wiki/Extension:SwiftMedia ...? If this is now part of code MW could we move the rewriting work there?

gerritbot added a comment.Dec 7 2021, 4:46 PM

Change 744827 had a related patch set uploaded (by MVernon; author: MVernon):

[operations/puppet@production] swift::proxy: install python{3,}-monotonic

https://gerrit.wikimedia.org/r/744827

gerritbot added a project: Patch-For-Review.Dec 7 2021, 4:46 PM
gerritbot added a comment.Dec 8 2021, 10:29 AM

Change 744827 merged by MVernon:

[operations/puppet@production] swift::proxy: install python{3,}-monotonic

https://gerrit.wikimedia.org/r/744827

Maintenance_bot removed a project: Patch-For-Review.Dec 8 2021, 11:10 AM
fgiunchedi added a comment.Dec 8 2021, 11:30 AM
In T296289#7553346, @MatthewVernon wrote:

OK, I know what the problem is (at least at one level). Our swift front-ends use a bit of middleware wmf.rewrite which is shipped by us from puppet; that calls import monotonic. But there's nothing to say that python-monotonic (or python3-monotonic) should be installed from swift front-ends as far as I can see.

I'm not sure what was causing python-monotonic to get installed in the past, but it might have just been luck! I'll have a look at puppetizing this.

@fgiunchedi while investigating this, I find in modules/swift/files/python3.9/SwiftMedia/README the note

The files in the wmf directory come from the svn repo for the SwiftMedia extension. That is the canonical copy; any changes here should be copied there as well.

I can only find signs of a long-deleted https://www.mediawiki.org/wiki/Extension:SwiftMedia ...? If this is now part of code MW could we move the rewriting work there?

AFAIK rewrite in puppet is now the canonical place for this work, i.e. SwiftMedia is no longer

gerritbot added a comment.Dec 8 2021, 3:41 PM

Change 745271 had a related patch set uploaded (by MVernon; author: MVernon):

[operations/puppet@production] swift: update README for rewrite middleware

https://gerrit.wikimedia.org/r/745271

gerritbot added a project: Patch-For-Review.Dec 8 2021, 3:41 PM
MatthewVernon claimed this task.EditedDec 8 2021, 3:42 PM
In T296289#7555901, @fgiunchedi wrote:

AFAIK rewrite in puppet is now the canonical place for this work, i.e. SwiftMedia is no longer

OK, I've put in a CR to update the READMEs, then I think we can close this.

gerritbot added a comment.Dec 8 2021, 4:43 PM

Change 745271 merged by MVernon:

[operations/puppet@production] swift: update README for rewrite middleware

https://gerrit.wikimedia.org/r/745271

MatthewVernon closed this task as Resolved.Dec 8 2021, 4:44 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 8 2021, 5:10 PM
fgiunchedi awarded a token.Dec 9 2021, 8:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL