Page MenuHomePhabricator
Create Task
Maniphest T296308

Consider moving bundlesize.config.json info into ResourceLoaderModule definitions
Closed, DeclinedPublic
Actions

Description

Following-up from T255149, in https://gerrit.wikimedia.org/r/c/737767 an idea came up to move the bundlesize.config.json definitions into the ResourceLoaderModule definitions. So instead of a file like bundlesize.config.json that contains this information:

[
	{
		"resourceModule": "skins.minerva.base.styles",
		"maxSize": "6.6KB"
	},
        ...
]

We'd update the skin.json to have something like:

"ResourceModules": {
		"skins.minerva.base.styles": {
                       "maxSize": "6.6KB",
			"class": "MediaWiki\\Minerva\\ResourceLoaderSkinModule",
			"features": [ "i18n-ordered-lists", "content-body", "content-links" ],
			"targets": [
				"mobile",
				"desktop"
			],
			"styles": [
				"resources/skins.minerva.base.styles/skin.less",
				"resources/skins.minerva.base.styles/content/index.less"
			]
		},

Related Objects

Event Timeline

kostajh created this task.Nov 23 2021, 3:56 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptNov 23 2021, 3:56 PM
kostajh added a project: MediaWiki-ResourceLoader.Nov 23 2021, 3:57 PM
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Nov 27 2021, 11:55 PM
Krinkle moved this task from Inbox, needs triage to Radar on the Performance-Team board.Nov 29 2021, 7:47 PM
Krinkle edited projects, added: Performance-Team (Radar); removed: Performance-Team.
Krinkle triaged this task as Medium priority.Dec 7 2021, 7:25 PM
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.
Krinkle updated the task description. (Show Details)
Krinkle moved this task from Inbox to Backlog on the MediaWiki-ResourceLoader board.
kostajh added a comment.Dec 8 2021, 9:06 AM

One downside is that the npm tool wouldn't work with the ResourceLoaderModule definitions. Maybe that doesn't matter if we want people to run bundlesize checks with composer test:size.

Jdlrobson added a comment.Dec 8 2021, 10:49 PM

I'd personally prefer keeping this out of ResourceLoader. If we ever decided the tool wasn't useful it will be easier to remove (And detect usage) if it's in a standalone configuration file. It's also not needed outside CI.

I think we had a similar conversation a while back about whether to put bundlesizeconfig in package.json and decided we preferred multiple config files to putting everything in package.json

Krinkle closed this task as Declined.Dec 8 2021, 11:33 PM

Okay, let's start with T255149 for now and see how that goes for a while. Closing this out for now, but we can revisit it in a few months based on the experience gathered.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits