Page MenuHomePhabricator
Create Task
Maniphest T296320

[Sticky header] update styling of page title (*blocker*)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Description

The page title in the sticky header should use:

  • font-family: 'Linux Libertine','Georgia','Times',serif
  • font-size: 22px (or closest standardized option)

Screen Shot 2021-11-23 at 1.22.59 PM.png (1,243×265 px, 110 KB)

NOTE: this is a release blocker for the sticky header deployment

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update style for page title in sticky headerClare Mingmediawiki/skins/Vectormaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• alexhollender_WMF created this task.Nov 23 2021, 6:23 PM
• alexhollender_WMF added a parent task: T283505: [EPIC] Fixed "sticky" site header.
• alexhollender_WMF added a subscriber: cjming.Nov 23 2021, 6:26 PM
• alexhollender_WMF renamed this task from [Sticky header] update styling of page title to [Sticky header] update styling of page title (*blocker*).Nov 23 2021, 6:30 PM
• alexhollender_WMF updated the task description. (Show Details)
• alexhollender_WMF updated the task description. (Show Details)
LGoto triaged this task as High priority.Nov 23 2021, 6:40 PM
LGoto moved this task from Incoming to Sticky header on the Vector 2022 board.
LGoto set the point value for this task to 2.Nov 24 2021, 5:41 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
cjming claimed this task.Nov 24 2021, 7:24 PM
cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Nov 24 2021, 9:03 PM

Change 741723 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Update style for page title in sticky header

https://gerrit.wikimedia.org/r/741723

gerritbot added a project: Patch-For-Review.Nov 24 2021, 9:03 PM
cjming removed cjming as the assignee of this task.Nov 24 2021, 9:03 PM
cjming moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson claimed this task.Nov 29 2021, 6:15 PM
gerritbot added a comment.Nov 29 2021, 11:11 PM

Change 741723 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Update style for page title in sticky header

https://gerrit.wikimedia.org/r/741723

Jdlrobson reassigned this task from Jdlrobson to • alexhollender_WMF.Nov 29 2021, 11:20 PM
Jdlrobson moved this task from Code Review to Design Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.

@alexhollender this can be tested on the beta cluster
Move to sign off if happy with the change, or needs more work if not.
https://en.wikipedia.beta.wmflabs.org/wiki/Albert%20Einstein?useskinversion=2&vectorstickyheader=1

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 30 2021, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 30 2021, 12:10 AM
• alexhollender_WMF reassigned this task from • alexhollender_WMF to ovasileva.Nov 30 2021, 5:10 PM
• alexhollender_WMF moved this task from Design Review to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.

nice !

Screen Shot 2021-11-30 at 12.08.29 PM.png (1,180×646 px, 184 KB)

• alexhollender_WMF mentioned this in T294924: Sticky header: full feature design review.Dec 1 2021, 5:05 PM
ovasileva closed this task as Resolved.Dec 3 2021, 2:54 PM

Looks good!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits