Page MenuHomePhabricator
Create Task
Maniphest T296321

[Sticky header] decrease height of container
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Description

Currently the sticky header container has height: 3.75rem; (which results in 60px). The sticky header should be 50px tall.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update sticky header height.Clare Mingmediawiki/skins/Vectormaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• alexhollender_WMF created this task.Nov 23 2021, 6:25 PM
• alexhollender_WMF added a parent task: T283505: [EPIC] Fixed "sticky" site header.
LGoto triaged this task as High priority.Nov 23 2021, 6:40 PM
LGoto moved this task from Incoming to Sticky header on the Vector 2022 board.
LGoto set the point value for this task to 2.Nov 24 2021, 5:44 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
cjming claimed this task.Nov 24 2021, 9:17 PM
cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Nov 24 2021, 9:21 PM

Change 741729 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Update sticky header height.

https://gerrit.wikimedia.org/r/741729

gerritbot added a project: Patch-For-Review.Nov 24 2021, 9:21 PM
cjming removed cjming as the assignee of this task.Nov 24 2021, 9:21 PM
cjming moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson claimed this task.Nov 29 2021, 6:15 PM
gerritbot added a comment.Nov 29 2021, 10:56 PM

Change 741729 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Update sticky header height.

https://gerrit.wikimedia.org/r/741729

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 29 2021, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 29 2021, 11:11 PM
Jdlrobson reassigned this task from Jdlrobson to • alexhollender_WMF.Nov 29 2021, 11:23 PM
Jdlrobson moved this task from Code Review to Design Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.

@alexhollender this can be tested on the beta cluster
Move to sign off if happy with the change, or needs more work if not.
https://en.wikipedia.beta.wmflabs.org/wiki/Albert%20Einstein?useskinversion=2&vectorstickyheader=1

• alexhollender_WMF reassigned this task from • alexhollender_WMF to ovasileva.Nov 30 2021, 5:11 PM
• alexhollender_WMF moved this task from Design Review to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.

awesome

Screen Shot 2021-11-30 at 12.10.40 PM.png (1,339×207 px, 78 KB)

• alexhollender_WMF mentioned this in T294924: Sticky header: full feature design review.Dec 1 2021, 5:05 PM
ovasileva closed this task as Resolved.Dec 1 2021, 5:29 PM

All done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits