Page MenuHomePhabricator
Create Task
Maniphest T296389

SX: Fix layout for infoboxes
Closed, ResolvedPublic
Actions

Assigned To
ngkountas
Authored By
ngkountas
Nov 24 2021, 12:55 PM
Tags
Referenced Files
F34806793: Screen Shot 2021-12-02 at 12.42.14 AM.png
Dec 2 2021, 5:45 AM
F34797142: Screen Shot 2021-11-30 at 5.57.35 PM.png
Nov 30 2021, 10:57 PM
F34764635: Screenshot 2021-11-24 at 3.33.32 PM.png
Nov 24 2021, 1:55 PM
F34764557: Screenshot 2021-11-24 at 2.09.23 PM.png
Nov 24 2021, 12:55 PM
Subscribers
Aklapper
• imaigwilo
Masumrezarock100
ngkountas

Description

The layout of the infoboxes inside Section Translation application doesn't follow the styles of infoboxes in Minerva Neue skin (skin that serves mobile traffic for Wikimedia projects). That leads to a weird layout that goes out of the screen bounds as in the example below:

Screenshot 2021-11-24 at 2.09.23 PM.png (820×382 px, 176 KB)
.

These issues should be fixed and infoboxes should use the same styles as in Minerva Neue skin for a better UI.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
CX3 Build 0.1.0+20211129mediawiki/extensions/ContentTranslationwmf/1.38.0-wmf.9+7 -7
CX3 Build 0.1.0+20211129mediawiki/extensions/ContentTranslationmaster+7 -7
SX: Add styles to improve infobox layoutmediawiki/extensions/ContentTranslationmaster+47 -1
Customize query in gerrit

Event Timeline

ngkountas created this task.Nov 24 2021, 12:55 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptNov 24 2021, 12:55 PM
ngkountas added a project: SectionTranslation.Nov 24 2021, 12:55 PM
ngkountas moved this task from Priority: SX Adoption to In Progress on the Language-Team (Language-2021-October-December) board.Nov 24 2021, 1:20 PM
ngkountas added a comment.EditedNov 24 2021, 1:55 PM

Infobox after fix:

Screenshot 2021-11-24 at 3.33.32 PM.png (820×382 px, 171 KB)

ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2021-October-December) board.Nov 24 2021, 1:58 PM
gerritbot added a comment.Nov 24 2021, 1:59 PM

Change 741676 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Add styles to improve infobox layout

https://gerrit.wikimedia.org/r/741676

gerritbot added a project: Patch-For-Review.Nov 24 2021, 1:59 PM
gerritbot added a comment.Nov 25 2021, 9:58 AM

Change 741676 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Add styles to improve infobox layout

https://gerrit.wikimedia.org/r/741676

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 25 2021, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 25 2021, 10:10 AM
santhosh triaged this task as Medium priority.Nov 25 2021, 10:55 AM
santhosh moved this task from In Review to Needs QA on the Language-Team (Language-2021-October-December) board.
gerritbot added a comment.Nov 29 2021, 6:36 AM

Change 742284 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742284

gerritbot added a project: Patch-For-Review.Nov 29 2021, 6:36 AM
gerritbot added a comment.Nov 29 2021, 4:19 PM

Change 742284 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742284

Maintenance_bot removed a project: Patch-For-Review.Nov 29 2021, 5:11 PM
• imaigwilo subscribed.EditedNov 30 2021, 10:57 PM

Test url: https://sx.wmflabs.org/index.php?title=Special:ContentTranslation&mobileaction=toggle_view_mobile&page=Ruth%20D%C3%ADaz&from=es&to=en&sx=true#/sx/sentence-selector
Screen shot on Beta mobile:

Screen Shot 2021-12-02 at 12.42.14 AM.png (1×892 px, 334 KB)

gerritbot added a comment.Dec 1 2021, 3:04 AM

Change 742849 had a related patch set uploaded (by KartikMistry; author: Santhosh):

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742849

gerritbot added a project: Patch-For-Review.Dec 1 2021, 3:04 AM
gerritbot added a comment.Dec 1 2021, 3:19 AM

Change 742849 abandoned by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

Reason:

Need to fix Merge Conflict first.

https://gerrit.wikimedia.org/r/742849

Maintenance_bot removed a project: Patch-For-Review.Dec 1 2021, 4:10 AM
gerritbot added a comment.Dec 1 2021, 6:09 AM

Change 742849 restored by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742849

gerritbot added a project: Patch-For-Review.Dec 1 2021, 6:09 AM
• imaigwilo moved this task from Needs QA to Recheck after deployment on the Language-Team (Language-2021-October-December) board.Dec 2 2021, 5:46 AM
gerritbot added a comment.Dec 2 2021, 12:47 PM

Change 742849 abandoned by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

Reason:

https://gerrit.wikimedia.org/r/742849

Pginer-WMF closed this task as Resolved.Dec 17 2021, 10:48 AM
Pginer-WMF moved this task from Recheck after deployment to Done on the Language-Team (Language-2021-October-December) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits