Maniphest T296401

Fix-It Week: Audit Existing TODOs and FIXMEs in WikiLambda PHP code
Open, In Progress, LowPublic
Actions

Description

Look at each use of FIXME, TODO, HACK, and similar inline comments in the WikiLambda extension's PHP code.
Check if each one of them names a Phabricator task by ID (e.g. // (T12345) TODO: This should be factored out into an interface).
If such a task doesn't yet exist, create one, tagged with Abstract Wikipedia team and Abstract Wikipedia Fix-It tasks, and other tasks as appropriate.
If such a task already exists, check that it's still open; if not, comment on the task asking if the comment is still valid or otherwise check if it has since been resolved or over-taken by events. If it has, make a patch removing the comment and explaining why we no longer want to do it.

Details

	Subject	Repo	Branch	Lines +/-
	doc: Add a Phabricator task reference for all inline TODO/FIXMEs	mediawiki/extensions/WikiLambda	master	+79 -60
	Add tasks for various TODOs and FIXMEs	mediawiki/extensions/WikiLambda	master	+12 -12
	Add phab IDs to FIXMEs and TODOs	mediawiki/extensions/WikiLambda	master	+30 -34

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		None	T296322 Fix-It Week: Audit Existing TODOs and FIXMEs to make sure all have a Phab ticket
		In Progress		Jdforrester-WMF	T296401 Fix-It Week: Audit Existing TODOs and FIXMEs in WikiLambda PHP code

Event Timeline

Jdforrester-WMF created this task.Nov 24 2021, 3:18 PM

Jdforrester-WMF moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Nov 24 2021, 5:19 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.

Jdforrester-WMF updated the task description. (Show Details)Nov 29 2021, 2:09 PM

Jdforrester-WMF assigned this task to gengh.Nov 30 2021, 4:55 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia Fix-It tasks; removed good first task.Jan 18 2022, 7:53 PM

gengh removed gengh as the assignee of this task.Jan 20 2022, 12:19 PM

gengh subscribed.

gengh claimed this task.Jan 31 2022, 1:29 PM

gengh updated the task description. (Show Details)

Change 758480 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Add phab IDs to FIXMEs and TODOs

https://gerrit.wikimedia.org/r/758480

gerritbot added a project: Patch-For-Review.Jan 31 2022, 3:17 PM

Change 758480 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add phab IDs to FIXMEs and TODOs

https://gerrit.wikimedia.org/r/758480

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 31 2022, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 31 2022, 4:10 PM

gengh removed gengh as the assignee of this task.Apr 1 2022, 1:48 PM

Jdforrester-WMF removed a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jul 25 2022, 1:15 PM

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:32 PM

Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:43 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).

Jdforrester-WMF triaged this task as Low priority.Mar 24 2023, 1:09 AM

Change 927742 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Add tasks for various TODOs and FIXMEs

https://gerrit.wikimedia.org/r/927742

gerritbot added a project: Patch-For-Review.Jun 6 2023, 4:55 PM

Change 927742 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add tasks for various TODOs and FIXMEs

https://gerrit.wikimedia.org/r/927742

Maintenance_bot removed a project: Patch-For-Review.Jun 7 2023, 5:10 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 7 2023, 6:00 PM

Mcastro moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.Thu, Apr 4, 4:54 PM

Change #1018734 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] doc: Add a Phabricator task reference for all inline TODO/FIXMEs

https://gerrit.wikimedia.org/r/1018734

gerritbot added a project: Patch-For-Review.Wed, Apr 10, 3:40 PM

Jdforrester-WMF changed the task status from Open to In Progress.Wed, Apr 10, 3:40 PM

Jdforrester-WMF claimed this task.

Jdforrester-WMF moved this task from Backlog to In Progress on the Abstract Wikipedia team board.

Change #1018734 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] doc: Add a Phabricator task reference for all inline TODO/FIXMEs

https://gerrit.wikimedia.org/r/1018734

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Thu, Apr 11, 8:00 AM