- Look at each use of FIXME, TODO, HACK, and similar inline comments in the Wikifunctions evaluator's code.
- Check if each one of them names a Phabricator task by ID (e.g. // (T12345) TODO: This should be factored out into an interface).
- If such a task doesn't yet exist, create one, tagged with Abstract Wikipedia team and Technical-Debt, and other tasks as appropriate.
- If such a task already exists, check that it's still open; if not, comment on the task asking if the comment is still valid or otherwise check if it has since been resolved or over-taken by events. If it has, make a patch removing the comment and explaining why we no longer want to do it.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Audit TODOs in function-evaluator. | mediawiki/services/function-evaluator | master | +10 -22 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Stalled | None | T296322 Fix-It Week: Audit Existing TODOs and FIXMEs to make sure all have a Phab ticket | |||
| Resolved | cmassaro | T296404 Fix-It Week: Audit Existing TODOs and FIXMEs in function evaluator code |
Event Timeline
Comment Actions
@Jdforrester-WMF: A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor. Given the lack of a task description && the lack of information where this codebase is located (no link on https://phabricator.wikimedia.org/tag/function-evaluator/ ) I'm removing the good first task tag. Please add details for a new contributor, and then add back the good first task project tag. Thanks a lot in advance!
Comment Actions
Change 742981 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):
[mediawiki/services/function-evaluator@master] Audit TODOs in function-evaluator.
Comment Actions
Change 742981 merged by jenkins-bot:
[mediawiki/services/function-evaluator@master] Audit TODOs in function-evaluator.