Page MenuHomePhabricator

Add an image: use highest ranking valid image
Closed, DuplicatePublic

Description

In the original specifications for T290045: Add an image: image inspector, we wrote:

The API will frequently provide multiple image suggestions. We should always offer the first one, which is the highest confidence one. For this iteration, we should ignore the other suggestions beyond the first one.

When we wrote that, we didn't realize that we would be filtering image matches based on our own criteria (see T296333: Add an image: exclude non-images and T296218: Add image: Set a minimum width for image suggestions). We want to change our logic so that when a user goes to an article, we give them the highest ranking valid suggestion. Only if none of its suggestions are valid should we show them the "No suggestions found" dialog.

This will improve the user experience in that users will see "no suggestions found" less frequently.

Event Timeline

@MMiller_WMF do you mean, filter out all invalid images and then use the first one? Or should the remaining images be ranked somehow? (How?)

PageImages and Page Content Service (two differently-architected approaches to the same goal, where unfortunately the newer one hasn't fully replaced the older one) select the "most representative" image in the article, based on various conditions (mostly position and image size). If the images in the article don't look appropriate, they won't select anything. The selected image is used in all kinds of software features (it's what we use in our task cards, but also it's used as a hero image in the apps, it's shown in search results, in the popups shown when hovering a link on desktop, in the VisualEditor link dialog etc); generally an article with a page image is a much nicer user experience than one without.

I wonder if it would make sense to align our filtering with the PI/PCS criteria so if some of the images are appropriate as page images and others aren't, we prefer the appropriate ones.

@MMiller_WMF do you mean, filter out all invalid images and then use the first one? Or should the remaining images be ranked somehow? (How?)

As far as I understand this refers to the first option: filter out all invalid images and then use the first one. I think the issue is created to make sure we don't show suggested edits on the feed that do not have any valid image recommendation after T296333: Add an image: exclude non-images and T296218: Add image: Set a minimum width for image suggestions are implemented.

I wonder if it would make sense to align our filtering with the PI/PCS criteria so if some of the images are appropriate as page images and others aren't, we prefer the appropriate ones.

I agree aligning this criteria make senses but I have two questions around:

  1. Are the IP/PCS criteria and our criteria aligned since these projects seem more general purpose? We were thinking that maybe it wouldn't be welcoming to show "explicit content" to newcomers. Not sure if this criteria makes sense in their context.
  2. Are these filters gonna be implemented in the image-recommendation API in the future or they are gonna remain as a request post-process in our extension?
kostajh triaged this task as High priority.Thu, Nov 25, 4:23 PM

Are the IP/PCS criteria and our criteria aligned since these projects seem more general purpose? We were thinking that maybe it wouldn't be welcoming to show "explicit content" to newcomers. Not sure if this criteria makes sense in their context.

I suppose this comes down to how much we care about Add Image as a content improvement mechanism for the wiki (as opposed to a retention / onboarding mechnism for new users, which is definitely the primary purpose, and for which PI/PCS criteria are irrelevant).

Are these filters gonna be implemented in the image-recommendation API in the future or they are gonna remain as a request post-process in our extension?

What I was thinking of was prioritizing PI/PCS compatible images in the extension post-processing step when there are multiple valid images. It's definitely not worth excluding an article or showing a "no suggestion" dialog over this.