Page MenuHomePhabricator

payment_final_status should accurately reflect status at processor
Open, Needs TriagePublic


DonationInterface has two status indicators that it sends in the payments-initial queue message - payment_final_status, which should reflect how the payment attempt fared at the processor, and validation_action, which reflects how our fraud filters judged it.

We are currently sending FAILED payment_final_status for anything that we fraud fail, regardless of what status it's in at the processor. Instead, let's send the actual payment status from the last processor API call. Note that this may require some changes to the finalize method in gateway adapter so it takes the validation action into account.

Should coordinate with fundraising analytics on how they use the payments_final_status - they'll be able to adapt by looking at the validation_action too.