Page MenuHomePhabricator

[arwiki] Add image - a question mark not in RTL format
Closed, ResolvedPublic

Description

@Dyolf77_WMF

The question mark in the SE card needs RTL variant:

Screen Shot 2021-11-24 at 1.43.23 PM.png (1×2 px, 363 KB)

Assets:

LTR: RTL:

Event Timeline

@RHo — should this be a different asset or should we flip the existing one?

@RHo — should this be a different asset or should we flip the existing one?

Hi @mewoph - I've added both LTR and RTL on the task, thanks!

Thanks @RHo! For Hebrew, since the question mark is LTR, should we use the LTR asset or should there be a different asset where the question mark is to the left of the picture icon but it's not flipped?

Thanks @RHo! For Hebrew, since the question mark is LTR, should we use the LTR asset or should there be a different asset where the question mark is to the left of the picture icon but it's not flipped?

Thanks for checking on Hebrew @mewoph - I think we should continue to use she LTR asset since the other image icons still shown the same mountain orientation as LTR (smaller peak on LHS):

image.png (148×316 px, 8 KB)
image.png (384×236 px, 21 KB)

Change 742500 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: Add RTL asset for placeholder-with-question-mark

https://gerrit.wikimedia.org/r/742500

Change 742500 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: Add RTL asset for placeholder-with-question-mark

https://gerrit.wikimedia.org/r/742500

Checked on arwiki wmf.12 - the fix is in place.