Fix VE Dialog shortcuts not working on some OS/Browser combos
Closed, InvalidPublicBUG REPORT
Actions

Assigned To

None

Authored By

	ECohen_WMDE
	Nov 25 2021, 10:31 AM

Description

The shortcuts added in T290262: Add keyboard shortcuts for VE template dialog do not seem to be working consistently for all users across different operating systems and browsers. Issues detected so far:

Chrome 97 on macOS (Monterey)

Cmd+Del not deleting parts of multi-part template content (checked on both wikitext and templates)
Cmd+Shift+ Up/Down is not moving the parts of multi-part template content (checked on both wikitext and templates)

Firefox 96 on Ubuntu Linux

Ctrl+Del not deleting parts of multi-part template content
Ctrl+Shift+ Up/Down is not moving the parts of multi-part template content

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T289653 Screenreader support for the new VisualEditor template editor sidebar
Resolved		thiemowmde	T290262 Add keyboard shortcuts for VE template dialog
Open		None	T294521 Finishing touches on keyboard shortcuts in the new template dialog
Invalid	BUG REPORT	None	T296463 Fix VE Dialog shortcuts not working on some OS/Browser combos

Event Timeline

ECohen_WMDE created this task.Nov 25 2021, 10:31 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 25 2021, 10:31 AM

thiemowmde added a project: WMDE-TechWish-Maintenance.Jan 14 2022, 2:14 PM

ECohen_WMDE added a parent task: T294521: Finishing touches on keyboard shortcuts in the new template dialog.Jan 19 2022, 9:58 AM

ECohen_WMDE updated the task description. (Show Details)Jan 19 2022, 10:11 AM

ECohen_WMDE updated the task description. (Show Details)Jan 19 2022, 10:13 AM

ECohen_WMDE updated the task description. (Show Details)Jan 19 2022, 10:19 AM

ECohen_WMDE mentioned this in T294521: Finishing touches on keyboard shortcuts in the new template dialog.Jan 19 2022, 11:20 AM

ECohen_WMDE renamed this task from [Draft] VE Template Dialog shortcuts not working consistently to Fix VE Dialog shortcuts not working on some OS/Browser combos.Jan 19 2022, 11:25 AM

• Timur_Vorkul_WMDE updated the task description. (Show Details)Jan 19 2022, 12:17 PM

ECohen_WMDE moved this task from In preparation to Ready for story time on the WMDE-Templates-FocusArea board.Jan 19 2022, 1:47 PM

I tested this on FF 93.0 Ubuntu Linux. It seems to work for me. Might be a confusion what needs to be in focus / selected to make the shortcuts work. Let's try to figure that out first.

Lena_WMDE moved this task from Ready for story time to Ready for pickup on the WMDE-Templates-FocusArea board.Jan 19 2022, 2:37 PM

@WMDE-Fisch You're right! Just tested but only with keyboard, selecting with the spacebar instead of with the mouse, and both worked. Seems like that's the source of the problem. Will discuss with @Lena_WMDE

ECohen_WMDE moved this task from Ready for pickup to In preparation on the WMDE-Templates-FocusArea board.Jan 19 2022, 2:43 PM

lilients_WMDE mentioned this in T299490: Add shortcuts to hover tooltips on buttons in adv toolbar.Jan 24 2022, 11:04 AM

Note: This should be improved now. Changes in T300971: Replace special behavior for Ctrl+Up/Down/Delete hotkeys in template dialog should make sure, that the keyboard interactions work with the "selected" parts. So the same as the buttons do. We also added Cmd/Ctrl + Backspace as alias for the deletion.

@WMDE-Fisch Confirmed today in story time. I'm closing this as invalid since this was not really the bug that was happening and the problem has been resolved.

Fix VE Dialog shortcuts not working on some OS/Browser combosClosed, InvalidPublicBUG REPORTActions

Description

Related ObjectsSearch...

Event Timeline

Fix VE Dialog shortcuts not working on some OS/Browser combos
Closed, InvalidPublicBUG REPORT
Actions

Related Objects
Search...