Page MenuHomePhabricator

Vector's 'expandablesearch' component is broken
Closed, DeclinedPublic

Description

Author: GICodeWarrior

Description:
Screen capture of the problem

When you focus the search box, it will expand inside a statically sized div with overflow auto and scrollbars will fill the entire space.

The module doesn't appear to have been touched since the last time I updated. So, there must have been a change to the Vector skin that caused it to break. I am running the MediaWiki and extension code from trunk.


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz27647

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 11:30 PM
bzimport added a project: Vector.
bzimport set Reference to bz27647.
TheDJ added a comment.Feb 27 2011, 8:36 PM

It indeed seems that the current vector styling of the searchfield is no longer compatible with this JS extension. Should we simply remove the module, or does anyone want to fix it ?

assigning to tarball blocker, so we need to make a decision by then.

Think we decided this one isn't a blocker.

Yes, i added comments to the source help explain that the expandable search is NOT ment to be used in the wild.

Marking as WFM; the entire search suggestions feature has been since reworked and merged into core, so this is probably no longer valid.

GICodeWarrior wrote:

This feature is still broken. It should probably be removed. In any case, I have no expectation that someone will make it work again. Switching resolution to WONTFIX.

Uh, I may have misunderstood this at first. This isn't about the search suggestions, but about the 'expandablesearch' component of the Vector extension?

In this case, there is currently a push to make the good parts of it into core MediaWiki. If you're interested in having this part cleaned up and merged (or even more, willing to do it yourself), please head to bug 46515 :)

Change 84195 had a related patch set uploaded by Bartosz Dziewoński:
Delete the ext.vector.expandableSearch module

https://gerrit.wikimedia.org/r/84195

Change 84195 merged by jenkins-bot:
Delete the ext.vector.expandableSearch module

https://gerrit.wikimedia.org/r/84195

Personally, I'd be 'interested' in fixing the feature... if I had the time.

There is no reason this can't be reimplemented in core in the future, but Vector's implementation kinda sucked, to be honest.

Given that the component is now gone, I'm going to close this bug as WONTFIX.