Page MenuHomePhabricator

Add an image: Investigate removing tasks from a user's queue after they have rejected them
Closed, ResolvedPublic

Description

Some image recommendation rejection reasons have to do with the image (e.g. irrelevant); when this happens we remove the task from the list of valid tasks (by sending a delete request to the search index). Other reasons have to do with the user (e.g. doesn't speak the language the image description is in); we don't want to show the image to that user again, but we do want to show it to other users. It's unclear what mechanism we could use for that.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

For Add Link we have the growthexperiments_link_submissions table. We could use a similar table to at least keep track of which user rejected what. There's some abandoned work towards that in T289024: Add Image: Backend handling of user acceptance/rejection of image recommendations. But it's still unclear how we'd combine that with search results.

Change 741948 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] AddImage: Refresh user's task feed after undecided rejection

https://gerrit.wikimedia.org/r/741948

Copying relevant comments from another task:

@RHo following up from T290315: Add Link: Ensure user does not see invalid tasks in task queue. Currently, if the user rejects a task with the reasons of unfamiliar or foreignlanguage, the task is not removed from the pool of image recommendation tasks available to all users. That means the user could possibly encounter it in their suggested edits feed again.

One option is to refresh the user's feed of tasks after they've submitted an accept/reject (or just reject) action for an image recommendation. If the user's filters are sufficiently broad (i.e. they don't have a single topic for example that for some reason has only a few tasks) then it's unlikely they'd see that specific task again.

To be consistent with the other tasks (unstructured, and add link), in this patch I am resetting the user's task set cache only if they do a rejeciton action using the "undecided" reasons.

Change 741948 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AddImage: Refresh user's task feed after undecided rejection

https://gerrit.wikimedia.org/r/741948

Change 742262 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.9] AddImage: Refresh user's task feed after undecided rejection

https://gerrit.wikimedia.org/r/742262

Change 742262 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.9] AddImage: Refresh user's task feed after undecided rejection

https://gerrit.wikimedia.org/r/742262

Mentioned in SAL (#wikimedia-operations) [2021-11-29T20:23:21Z] <tgr@deploy1002> Synchronized php-1.38.0-wmf.9/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/AddImageSubmissionHandler.php: Backport: [[gerrit:742262|AddImage: Refresh user's task feed after undecided rejection (T296491)]] (duration: 00m 56s)

@kostajh, @Tgr - please review the following on whether it's the expected behavior or some more work needs to be done.

Checked on testwiki wmf.13 and cswiki wmf.13 - the current behavior is as the following (it's consistently reproducible) - the image which was rejected with "Not sure" reason or with "No" ( the answers "I don't know this subject" or "I can't read the language in the image details") are still in int user's result set.

(1) "Not sure"

  • a user selects a topic and the "Add image" filter - gets the results (e.g in my testing the number of results was 6 and 70)
  • a user goes to one of the articles and answers "Not sure"
  • returns to Suggested edits; the number of returned results is still the same and the undecided article is still in the feed

(2)

  • a user selects a topic and the "Add image" filter - gets the results
  • a user goes to one of the articles and answers "I don't know this subject" or "I can't read the language in the image details"
  • returns to Suggested edits; the number of returned results is still the same and the article for which the image was is still in the feed

@Etonkovidova that's sort of correct. For (2) the user should get a new set of tasks, which hopefully doesn't include the task they just rejected, but in case of a small result set there's no guarantee.