Page MenuHomePhabricator
Create Task
Maniphest T296493

SX Pick a sentence: Wrong paddings for action buttons
Closed, ResolvedPublic
Actions

Description

The padding of the "Previous" and "Skip" action inside "Pick a sentence" step have no padding, as shown in the screenshot below:

Screenshot 2021-11-25 at 7.45.07 PM.png (568×774 px, 76 KB)

They should be fixed to match specifications.

Details

SubjectRepoBranchLines +/-
CX3 Build 0.1.0+20211210mediawiki/extensions/ContentTranslationmaster+2 -2
SX ProposedTranslationActionButtons: Fix padding for action buttonsmediawiki/extensions/ContentTranslationmaster+12 -9
Customize query in gerrit

Event Timeline

ngkountas created this task.Nov 25 2021, 5:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 25 2021, 5:48 PM
ngkountas moved this task from Priority: SX Adoption to In Progress on the Language-Team (Language-2021-October-December) board.Nov 25 2021, 5:48 PM
ngkountas added a comment.Nov 25 2021, 5:50 PM

Screenshot after fix

Screenshot 2021-11-25 at 7.48.40 PM.png (568×774 px, 76 KB)

gerritbot added a comment.Nov 25 2021, 6:43 PM

Change 741950 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX ProposedTranslationActionButtons: Fix padding for action buttons

https://gerrit.wikimedia.org/r/741950

gerritbot added a project: Patch-For-Review.Nov 25 2021, 6:43 PM
• santhosh moved this task from In Progress to In Review on the Language-Team (Language-2021-October-December) board.Nov 26 2021, 6:52 AM
gerritbot added a comment.Nov 30 2021, 9:13 AM

Change 741950 merged by Nik Gkountas:

[mediawiki/extensions/ContentTranslation@master] SX ProposedTranslationActionButtons: Fix padding for action buttons

https://gerrit.wikimedia.org/r/741950

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 30 2021, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 30 2021, 10:10 AM
gerritbot added a comment.Dec 10 2021, 6:59 PM

Change 745934 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211210

https://gerrit.wikimedia.org/r/745934

gerritbot added a project: Patch-For-Review.Dec 10 2021, 6:59 PM
gerritbot added a comment.Dec 13 2021, 8:21 AM

Change 745934 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211210

https://gerrit.wikimedia.org/r/745934

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2021, 9:10 AM
Pginer-WMF triaged this task as Medium priority.Dec 17 2021, 10:51 AM
Pginer-WMF edited projects, added Language-Team (Language-2022-January-March); removed Language-Team (Language-2021-October-December).Jan 10 2022, 3:22 PM
Pginer-WMF moved this task from Quarter Backlog to In Review on the Language-Team (Language-2022-January-March) board.
ngkountas moved this task from In Review to Needs QA on the Language-Team (Language-2022-January-March) board.Jan 11 2022, 2:09 PM
Pginer-WMF closed this task as Resolved.Jan 14 2022, 10:11 AM
Pginer-WMF moved this task from Needs QA to Done on the Language-Team (Language-2022-January-March) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL