Page MenuHomePhabricator

Merge maps revid varnish changes
Closed, DeclinedPublic

Description

Port the proof-of-concept varnish rules to production and beta cluster varnish. Put the complex regex behind a simpler guard condition for /\<revid=/. This reduces the risk of jiggling legacy requests.

Task is complete once revid is cache-invariant.

Production deployment should be monitored, but isn't expected to change anything about current "legacy" requests which do not include a revid.

Code:

Event Timeline

awight removed awight as the assignee of this task.
awight updated the task description. (Show Details)
awight moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2021-11-24 board.

Moving back to the backlog. The guard condition is in a POC branch, ready for review.

Change 742148 had a related patch set uploaded (by Awight; author: Awight):

[operations/puppet@production] [WIP] Maps are invariant to revid parameter

https://gerrit.wikimedia.org/r/742148

Change 742148 abandoned by Awight:

[operations/puppet@production] Maps are invariant to revid parameter

Reason:

Dropping this change from our plan. If the maps cache is impacted, we'll come back to it and possibly implement something similar where revid is hidden from ATS but passed internally via a new header.

https://gerrit.wikimedia.org/r/742148