Page MenuHomePhabricator

Role hieradata for non-existent roles
Open, LowPublic

Description

The following role hiera files exist without corresponding role files:

hieradata/role/common/wmcs/ceph/backup.yaml
hieradata/role/common/osm/slave.yaml
hieradata/role/common/labsencapi.yaml
hieradata/role/common/wmcs/web_interfaces.yaml
hieradata/role/common/wmcs/nfs/misc.yaml
hieradata/role/common/postgres/master.yaml
hieradata/role/common/ml_serve.yaml
hieradata/role/common/wmcs/nfs/misc_backup.yaml
hieradata/role/common/snapshot/producer.yaml
hieradata/role/common/analytics.yaml
hieradata/role/common/kafka/monitoring.yaml
hieradata/role/common/mariadb/labs_deprecated.yaml
hieradata/role/common/swift/swiftrepl.yaml
hieradata/role/common/snapshot/dumper.yaml
hieradata/role/common/graphite.yaml
hieradata/role/common/eventlogging/analytics/legacy.yaml
hieradata/role/common/analytics_test_cluster/superset.yaml
hieradata/role/common/redisdb.yaml
hieradata/role/eqiad/labs/puppetmaster.yaml
hieradata/role/eqiad/labs/openstack/nova/network.yaml
hieradata/role/eqiad/kafka/monitoring.yaml
hieradata/role/codfw/wmcs/ceph/backup.yaml
hieradata/role/codfw/wmcs/openstack/codfw1dev/virt_ceph_and_backy.yaml
hieradata/role/codfw/kafka/monitoring.yaml

(generated using P17881)

Can they just be removed?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 761355 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] hieradata: Remove data for non-existent roles

https://gerrit.wikimedia.org/r/761355

Change 761355 merged by Jbond:

[operations/puppet@production] hieradata: Remove data for non-existent roles

https://gerrit.wikimedia.org/r/761355

Change 761397 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] utils: add script to audit role hiera files

https://gerrit.wikimedia.org/r/761397

Change 989086 had a related patch set uploaded (by Muehlenhoff; author: Muehlenhoff):

[operations/puppet@production] Remove obsolete Hiera files

https://gerrit.wikimedia.org/r/989086

Change 989086 merged by Muehlenhoff:

[operations/puppet@production] Remove obsolete Hiera files

https://gerrit.wikimedia.org/r/989086

SLyngshede-WMF subscribed.

Todo: Grab the python script from @taavi, clean up, if required and put into Puppet.