Maniphest T296542

Replace all references to Zxxx with Constant variable to increase readability in WikiLambda's Vue code
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	SimoneThisDot
	Nov 26 2021, 2:34 PM

Tags

Referenced Files

None

Subscribers

Description

As a user I would like to replace all the reference of zObject in the Vue and JS files to use the actual Constants variable (resources\ext.wikilambda.edit\Constants.js).

So for example if you find "Z1" you should replace it with Constants.Z_OBJECT, or if you find Z6K1 replace it with Constants.Z_STRING_VALUE.

Update all .vue file
Update all .js file (mainly store)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	update constants in vue and js files	mediawiki/extensions/WikiLambda	master	+89 -70
	FnEditorName.vue: switch to using a constant for zobject	mediawiki/extensions/WikiLambda	master	+1 -1

Customize query in gerrit

Event Timeline

SimoneThisDot created this task.Nov 26 2021, 2:34 PM

Nishu02 subscribed.Nov 27 2021, 7:26 AM

SimoneThisDot renamed this task from Replace all reference to Zxxx with Constant variable` to Replace all reference to Zxxx with Constant variable to increase readibility.Nov 29 2021, 10:59 AM

Jdforrester-WMF renamed this task from Replace all reference to Zxxx with Constant variable to increase readibility to Replace all references to Zxxx with Constant variable to increase readability in WikiLambda's Vue code.Nov 29 2021, 2:12 PM

Jdforrester-WMF updated the task description. (Show Details)

• JKieserman claimed this task.Nov 29 2021, 4:53 PM

Jdforrester-WMF moved this task from Launch Beta Cluster wikifunctions.org to Phase κ – Clean-up on the Abstract Wikipedia team board.Nov 29 2021, 8:26 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.

Change 742532 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] FnEditorName.vue: switch to using a constant for zobject

https://gerrit.wikimedia.org/r/742532

gerritbot added a project: Patch-For-Review.Nov 29 2021, 8:35 PM

Change 742532 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] FnEditorName.vue: switch to using a constant for zobject

https://gerrit.wikimedia.org/r/742532

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 29 2021, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 29 2021, 9:10 PM

Change 742758 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] update constants in vue and js files

https://gerrit.wikimedia.org/r/742758

gerritbot added a project: Patch-For-Review.Nov 30 2021, 4:02 PM

Change 742758 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] update constants in vue and js files

https://gerrit.wikimedia.org/r/742758

Maintenance_bot removed a project: Patch-For-Review.Dec 1 2021, 1:10 PM

Jdforrester-WMF closed this task as Resolved.Dec 1 2021, 2:43 PM