Page MenuHomePhabricator
Create Task
Maniphest T296548

[openstack.horizon] Going to the interfaces tab of puppet-diffs/pcc-db1001 throws 500
Closed, ResolvedPublic
Actions

Description

It seems that at least jbond and I get that error, from firefox:

curl 'https://horizon.wikimedia.org/project/instances/79091983-20ae-44a5-a180-f21ac6663959/?tab=instance_details__interfaces' \
  -H 'User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0' \
  -H 'Accept: text/html, */*; q=0.01' \
  -H 'Accept-Language: en,en-US;q=0.8,es-ES;q=0.5,es;q=0.3' --compressed \
  -H 'X-Requested-With: XMLHttpRequest' \
  -H 'Connection: keep-alive' \
  -H 'Referer: https://horizon.wikimedia.org/project/instances/79091983-20ae-44a5-a180-f21ac6663959/' \
  -H 'Cookie: tabs=%7B%22instance_details%22%3A%22%23instance_details__interfaces%22%7D; WMF-Last-Access=26-Nov-2021; sessionid=REDACTED; GeoIP=FR:ARA:REDACTED:REDACTED:6.08:v4; csrftoken=REDACTED; recent_project=puppet-diffs' \
  -H 'Pragma: no-cache' \
  -H 'Cache-Control: no-cache' \
  -H 'TE: Trailers'

Details

SubjectRepoBranchLines +/-
Update horizon submoduleopenstack/horizon/deploymain+1 -1
Revert "Remove some networking panels"openstack/horizon/horizonmain+41 -0
Customize query in gerrit

Related Objects

Event Timeline

dcaro created this task.Nov 26 2021, 4:12 PM
jbond subscribed.Nov 26 2021, 4:14 PM
taavi added a project: Horizon.Nov 26 2021, 4:20 PM
Andrew subscribed.Nov 27 2021, 6:40 PM
2021-11-27 18:38:12.076543 django.template.exceptions.TemplateDoesNotExist: project/networks/ports/_port_ips.html

Most likely what's happening is that I disabled this tab and marked out all of the supporting code in an older version, and that something has changed to present the tab despite my attempts.

I will investigate whether it's easier to re-enable the tab or be more thorough about hiding it.

taavi subscribed.Nov 27 2021, 6:53 PM

The networks panel in Admin -> Network -> Networks seems to be broken in the same way.

Andrew added a comment.Nov 27 2021, 7:09 PM

It looks like this issue is because the interfaces tab is trying to pull in UI elements from the 'network' dashboard. Since we don't install the network dashboard these elements are unavailable.

Possibly we can install the network dashboard and then disable it via ACLs.

gerritbot added a comment.Nov 27 2021, 7:40 PM

Change 742225 had a related patch set uploaded (by Andrew Bogott; author: Andrew Bogott):

[openstack/horizon/horizon@main] Revert \"Remove some networking panels\"

https://gerrit.wikimedia.org/r/742225

gerritbot added a project: Patch-For-Review.Nov 27 2021, 7:40 PM
gerritbot added a comment.Nov 27 2021, 7:42 PM

Change 742225 merged by Andrew Bogott:

[openstack/horizon/horizon@main] Revert \"Remove some networking panels\"

https://gerrit.wikimedia.org/r/742225

gerritbot added a comment.Nov 27 2021, 7:43 PM

Change 742226 had a related patch set uploaded (by Andrew Bogott; author: Andrew Bogott):

[openstack/horizon/deploy@main] Update horizon submodule

https://gerrit.wikimedia.org/r/742226

gerritbot added a comment.Nov 27 2021, 7:43 PM

Change 742226 merged by Andrew Bogott:

[openstack/horizon/deploy@main] Update horizon submodule

https://gerrit.wikimedia.org/r/742226

Stashbot added a comment.Nov 27 2021, 7:51 PM

Mentioned in SAL (#wikimedia-operations) [2021-11-27T19:51:06Z] <andrew@deploy1002> Started deploy [horizon/deploy@6115b3b]: network UI updates for T296548

Stashbot added a comment.Nov 27 2021, 7:55 PM

Mentioned in SAL (#wikimedia-operations) [2021-11-27T19:55:20Z] <andrew@deploy1002> Finished deploy [horizon/deploy@6115b3b]: network UI updates for T296548 (duration: 04m 14s)

Andrew added a comment.Nov 27 2021, 7:57 PM

I re-enabled quite a lot of network features, including this one. I'm pretty sure that this is doing more good than harm but please let me know if anyone here thinks that I should switch off any of those panels back off.

dcaro added a comment.Nov 29 2021, 9:48 AM

Fancy UIs 🎉, specially the network topology and graph one (a bit scary that you can delete instances right there though).

dcaro reassigned this task from dcaro to Andrew.Nov 29 2021, 9:48 AM
dcaro removed a project: User-dcaro.
jbond added a comment.Nov 29 2021, 12:40 PM

LGTM thanks

Andrew closed this task as Resolved.Nov 29 2021, 3:06 PM
taavi merged a task: T290736: horizon has spinning loading symbol on instance interface tab.Nov 30 2021, 9:37 AM
taavi added subscribers: rook, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL