Page MenuHomePhabricator

"Mark all changes as seen" does not get applied to oversighted edits on meta
Closed, ResolvedPublicBUG REPORT

Description

Spotted at https://meta.wikimedia.org/wiki/Strategic_Wikimedia_Affiliates_Network on Meta. Despite having marked my watchlist as 'all changes seen' today, this diff from yesterday still appears in bold in my watchlist:

image.png (708×1 px, 285 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The bold is not for seen/unseen, it was added for revision deleted (suppression/oversight) things by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/678715 / T23272
Seems not useful for Special:Watchlist, because the same text gets bold from ".mw-changeslist-line-watched .mw-title" when unseen.

Checked on enwiki betalabs - the issue is confirmed: if the suppression option is clicked on Special:RevisionDelete, the bod will stay on Watchlist evn when "mark all changes as seen " will be clicked. in the screenshot below two entries were deleted. One was deleted without suppression- it changes to unbold when "Mark as seen"; when a revision was suppressed - the bold would stay.

Screen Shot 2021-12-02 at 6.19.10 PM.png (1×2 px, 438 KB)

Note: On RC the suppressed revisions will have double strike-out:

Screen Shot 2021-12-02 at 6.32.55 PM.png (474×1 px, 155 KB)

Change 743618 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Change style for class mw-history-suppressed from bold to grey (Base 10)

https://gerrit.wikimedia.org/r/743618

Change 743618 merged by jenkins-bot:

[mediawiki/core@master] Change style for class mw-history-suppressed from bold to grey (Base 10)

https://gerrit.wikimedia.org/r/743618

Umherirrender claimed this task.