Page MenuHomePhabricator
Create Task
Maniphest T296568

Undefined index: Movepage
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • create page with title Dowódów
  • press Move link

What happens?:

Browser displays
Internal error
[55621e4ad4c19bf687437933] 2021-11-27 14:58:21: Fatal exception of type "InvalidArgumentException"

No such error after disabling Translate extension in same Mediawiki installation.

Me be related: in webserver error log I can also see (not after error but on page opening):

PHP Notice: Undefined index: Movepage in /var/lib/mediawiki/extensions/Translate/tag/PageTranslationHooks.php on line 1207, referer:

What should have happened instead?:

Move page opened without errors.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Mediawiki from Debian 11 with MELB extensions from git added:

MediaWiki 1.35.4
PHP 7.4.25 (apache2handler)
MariaDB 10.5.12-MariaDB-0+deb11u1-log
ICU 67.1

Details

SubjectRepoBranchLines +/-
SpecialPage_initList: Return if MovePage is not setmediawiki/extensions/Translatemaster+6 -1
SpecialPage_initList: Return if MovePage is not setmediawiki/extensions/Translatemleb-2021.12+6 -1
Customize query in gerrit

Related Objects

Event Timeline

Pawel.boguslawski created this task.Nov 27 2021, 3:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 27 2021, 3:06 PM
Reedy added projects: MediaWiki-extensions-Translate, MW-1.35-release.Nov 27 2021, 3:08 PM
Pawel.boguslawski added a comment.Nov 27 2021, 3:26 PM

Extensions

Babel
cldr
CleanChanges
Translate
UniversalLanguageSelector

are installed from git tag 2021.11 (same problem in tag 2021.10).

bfgfdfvd subscribed.Nov 27 2021, 3:52 PM
Nikerabbit subscribed.Nov 29 2021, 12:17 PM

The first error is probably: T296450: Passing a raw class name is not allowed here. Use [ 'class' => $classname ] instead..

The PHP notice is weird though. Movepage should always be defined: https://gerrit.wikimedia.org/g/mediawiki/core/+/REL1_35/includes/specialpage/SpecialPageFactory.php#218

Nikerabbit added a comment.Nov 30 2021, 11:49 AM

Can you try again with the latest master branch of Translate?

Pawel.boguslawski added a comment.Dec 1 2021, 9:00 AM

Can you try again with the latest master branch of Translate?

Checked 84e9cea635a9bb10f49cee21a5a2c209753b9cd8:

(1) no InvalidArgumentException error on page moving (this issue seems to be resolved),

(2) notice "PHP Notice: Undefined index: Movepage in /var/lib/mediawiki/extensions/Translate/tag/PageTranslationHooks.php on line 1207, referer: [...]" still occurs in apache error.log (didn't fid way to reproduce - sometimes after opening main wiki page).

Reedy moved this task from Blocker to Not a blocker on the MW-1.35-release board.Dec 2 2021, 5:04 AM
gerritbot added a comment.Dec 2 2021, 11:19 AM

Change 743132 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] SpecialPage_initList: Return if MovePage is not set

https://gerrit.wikimedia.org/r/743132

gerritbot added a project: Patch-For-Review.Dec 2 2021, 11:19 AM
gerritbot added a comment.Dec 2 2021, 11:25 AM

Change 743134 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@mleb-2021.12] SpecialPage_initList: Return if MovePage is not set

https://gerrit.wikimedia.org/r/743134

gerritbot added a comment.Dec 2 2021, 12:30 PM

Change 743134 merged by jenkins-bot:

[mediawiki/extensions/Translate@mleb-2021.12] SpecialPage_initList: Return if MovePage is not set

https://gerrit.wikimedia.org/r/743134

gerritbot added a comment.Dec 2 2021, 12:30 PM

Change 743132 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] SpecialPage_initList: Return if MovePage is not set

https://gerrit.wikimedia.org/r/743132

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 2 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 2 2021, 1:10 PM
abi_ claimed this task.Dec 6 2021, 2:51 PM
abi_ triaged this task as Medium priority.
abi_ added a project: Language-Team (Language-2021-October-December).
abi_ subscribed.
In T296568#7539969, @Pawel.boguslawski wrote:

Can you try again with the latest master branch of Translate?

Checked 84e9cea635a9bb10f49cee21a5a2c209753b9cd8:

(1) no InvalidArgumentException error on page moving (this issue seems to be resolved),

(2) notice "PHP Notice: Undefined index: Movepage in /var/lib/mediawiki/extensions/Translate/tag/PageTranslationHooks.php on line 1207, referer: [...]" still occurs in apache error.log (didn't fid way to reproduce - sometimes after opening main wiki page).

We were not able to reproduce this bug, but have added a check to avoid that notice. That's available in MLEB 2021.12. Can you please check if that helps?

abi_ moved this task from Quarter Backlog to Recheck after deployment on the Language-Team (Language-2021-October-December) board.Dec 6 2021, 2:52 PM
abi_ closed this task as Resolved.Dec 9 2021, 10:22 AM
abi_ moved this task from Recheck after deployment to Done on the Language-Team (Language-2021-October-December) board.

This warning should no longer appear. Feel free to reopen if you still have this issue.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL