Page MenuHomePhabricator

Undefined index: Movepage
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • create page with title Dowódów
  • press Move link

What happens?:

Browser displays
Internal error
[55621e4ad4c19bf687437933] 2021-11-27 14:58:21: Fatal exception of type "InvalidArgumentException"

No such error after disabling Translate extension in same Mediawiki installation.

Me be related: in webserver error log I can also see (not after error but on page opening):

PHP Notice: Undefined index: Movepage in /var/lib/mediawiki/extensions/Translate/tag/PageTranslationHooks.php on line 1207, referer:

What should have happened instead?:

Move page opened without errors.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Mediawiki from Debian 11 with MELB extensions from git added:

MediaWiki 1.35.4
PHP 7.4.25 (apache2handler)
MariaDB 10.5.12-MariaDB-0+deb11u1-log
ICU 67.1

Event Timeline

Extensions

Babel
cldr
CleanChanges
Translate
UniversalLanguageSelector

are installed from git tag 2021.11 (same problem in tag 2021.10).

Can you try again with the latest master branch of Translate?

Can you try again with the latest master branch of Translate?

Checked 84e9cea635a9bb10f49cee21a5a2c209753b9cd8:

(1) no InvalidArgumentException error on page moving (this issue seems to be resolved),

(2) notice "PHP Notice: Undefined index: Movepage in /var/lib/mediawiki/extensions/Translate/tag/PageTranslationHooks.php on line 1207, referer: [...]" still occurs in apache error.log (didn't fid way to reproduce - sometimes after opening main wiki page).

Change 743132 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] SpecialPage_initList: Return if MovePage is not set

https://gerrit.wikimedia.org/r/743132

Change 743134 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@mleb-2021.12] SpecialPage_initList: Return if MovePage is not set

https://gerrit.wikimedia.org/r/743134

Change 743134 merged by jenkins-bot:

[mediawiki/extensions/Translate@mleb-2021.12] SpecialPage_initList: Return if MovePage is not set

https://gerrit.wikimedia.org/r/743134

Change 743132 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] SpecialPage_initList: Return if MovePage is not set

https://gerrit.wikimedia.org/r/743132

abi_ triaged this task as Medium priority.
abi_ added a subscriber: abi_.

Can you try again with the latest master branch of Translate?

Checked 84e9cea635a9bb10f49cee21a5a2c209753b9cd8:

(1) no InvalidArgumentException error on page moving (this issue seems to be resolved),

(2) notice "PHP Notice: Undefined index: Movepage in /var/lib/mediawiki/extensions/Translate/tag/PageTranslationHooks.php on line 1207, referer: [...]" still occurs in apache error.log (didn't fid way to reproduce - sometimes after opening main wiki page).

We were not able to reproduce this bug, but have added a check to avoid that notice. That's available in MLEB 2021.12. Can you please check if that helps?

This warning should no longer appear. Feel free to reopen if you still have this issue.