Page MenuHomePhabricator

Remove !important from special page font declarations in minerva and increase specificity of rule
Open, LowPublic


When using the minerva skin on enwiki (and not on other projects such as eswiki or testwiki) the computed stylesheet:


The loaded rule is:

.ns-special h1,
.ns-special h2 {
font-family: -apple-system, 'BlinkMacSystemFont', 'Segoe UI', 'Roboto', 'Lato', 'Helvetica', 'Arial', sans-serif !important

The !important enhancer seems over used here, however we are having a hard time determining where this is being introduced to determine why it was introduced.

reported on-wiki in

Event Timeline

Suspect it is somewhere deep in mobilefrontend

Thank you for the tip, I saw very similar code in but I'm still at a loss for where the !important is coming from there - my code-search-fu must be lacking

Thank you! From T173597 ; @Jdlrobson is forcing this styling to "!important" necessary here - seems to be preventing userstyles from taking affect?

Xaosflux renamed this task from Overly !important font on enwiki in minerva to Overly !important font in minerva.Nov 28 2021, 11:49 PM

I don't think the !important is necessary here, but it needs to override .pre-content h1, .content h1, .content h2 so I think provided .ns-special h1, .ns-special h2 is replaced with .ns-special .pre-content h1, .ns-special .content h1, .content h2 a patch would be welcome to drop the !important.

I think originally the goal was to have consistent headings across pages because certain special pages were deviating from standard font families, but I don't think that's happening any more, and if it is, it's better fixed in the special page itself.

Jdlrobson renamed this task from Overly !important font in minerva to Remove !important from special page font declarations in minerva and increase specificity of rule.Nov 30 2021, 6:52 PM
Jdlrobson triaged this task as Low priority.

Is this issue still open to work? If yes, can anyone guide me through?

Aklapper added a subscriber: nilima_mahakur28.

@nilima_mahakur28: I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action...Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!