Page MenuHomePhabricator
Create Task
Maniphest T296598

Remove !important from special page font declarations in minerva and increase specificity of rule
Open, LowPublic
Actions

Description

When using the minerva skin on enwiki (and not on other projects such as eswiki or testwiki) the computed stylesheet:

<view-source:https://en.m.wikipedia.org/w/load.php?lang=en&modules=ext.wikimediaBadges%7Cmediawiki.hlist%7Cmediawiki.ui.button%2Ccheckbox%2Cicon%2Cinput%2Cradio%7Cmobile.init.styles%7Cmobile.pagelist.styles%7Cmobile.pagesummary.styles%7Cmobile.placeholder.images%7Cmobile.special.history.styles%7Cmobile.special.pagefeed.styles%7Cmobile.special.styles%7Cmobile.user.icons%7Cskins.minerva.amc.styles%7Cskins.minerva.base.styles%7Cskins.minerva.content.styles.images%7Cskins.minerva.icons.wikimedia%7Cskins.minerva.mainMenu.icons%2Cstyles%7Cskins.minerva.messageBox.styles&only=styles&skin=minerva>

The loaded rule is:

.ns-special h1,
.ns-special h2 {
font-family: -apple-system, 'BlinkMacSystemFont', 'Segoe UI', 'Roboto', 'Lato', 'Helvetica', 'Arial', sans-serif !important
}

The !important enhancer seems over used here, however we are having a hard time determining where this is being introduced to determine why it was introduced.

reported on-wiki in https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Elements_in_custom_CSS_disabled

Related Objects

Event Timeline

Xaosflux created this task.Nov 28 2021, 7:05 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptNov 28 2021, 7:05 PM
Xaosflux added a project: MobileFrontend.Nov 28 2021, 7:36 PM

Suspect it is somewhere deep in mobilefrontend

Izno added a subscriber: Izno.Nov 28 2021, 7:50 PM

This is being produced in https://en.m.wikipedia.org/w/load.php?debug=1&lang=en&modules=mobile.special.styles&only=styles&skin=minerva

Izno removed a subscriber: Izno.Nov 28 2021, 7:52 PM
Xaosflux added a comment.Nov 28 2021, 8:12 PM

Thank you for the tip, I saw very similar code in https://gerrit.wikimedia.org/g/mediawiki/extensions/MobileFrontend/+/ee9659197f39824d7fafd9b8a4ceb16c80ab6b4c/mobile.less/mobile.variables.less but I'm still at a loss for where the !important is coming from there - my code-search-fu must be lacking

Umherirrender added a subscriber: Umherirrender.Nov 28 2021, 8:40 PM

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/skins/MinervaNeue/+/98f2b02514d9933741d4c1af83544ffa036ca148/skinStyles/mobile.special.styles/minerva.less#60

Also refered under https://gerrit.wikimedia.org/g/mediawiki/extensions/GrowthExperiments/+/a59ea75bd9c17b80e74093c768a51f21c5b3ac8a/modules/homepage/ext.growthExperiments.Homepage.less#95

Was added with https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/372560

Xaosflux added a subscriber: Jdlrobson.Nov 28 2021, 9:44 PM

Thank you! From T173597 ; @Jdlrobson is forcing this styling to "!important" necessary here - seems to be preventing userstyles from taking affect?

Xaosflux renamed this task from Overly !important font on enwiki in minerva to Overly !important font in minerva.Nov 28 2021, 11:49 PM
Rummskartoffel added a subscriber: Rummskartoffel.Nov 29 2021, 10:34 AM
Jdlrobson edited projects, added patch-welcome, good first task, Web-Team-Backlog (Needs Prioritization (Tech)); removed MobileFrontend.Nov 30 2021, 6:52 PM

I don't think the !important is necessary here, but it needs to override .pre-content h1, .content h1, .content h2 so I think provided .ns-special h1, .ns-special h2 is replaced with .ns-special .pre-content h1, .ns-special .content h1, .content h2 a patch would be welcome to drop the !important.

I think originally the goal was to have consistent headings across pages because certain special pages were deviating from standard font families, but I don't think that's happening any more, and if it is, it's better fixed in the special page itself.

Jdlrobson renamed this task from Overly !important font in minerva to Remove !important from special page font declarations in minerva and increase specificity of rule.Nov 30 2021, 6:52 PM
Jdlrobson triaged this task as Low priority.
Jdlrobson moved this task from Backlog to Future Unplanned on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Dec 1 2021, 9:53 PM
Umherirrender removed a subscriber: Umherirrender.Jan 2 2022, 8:41 PM
Ankit18gupta added a subscriber: Ankit18gupta.Feb 3 2022, 7:49 AM

Greetings!!
Is this issue still open to work? If yes, can anyone guide me through?

Aklapper added a comment.Feb 3 2022, 8:18 AM

Hi @Ankit18gupta, please see https://www.mediawiki.org/wiki/New_Developers#Some_general_communication_tips and provide specific questions - thanks! :)

Jdlrobson moved this task from Future Unplanned to Consolidate frontend code approaches in Minerva and Vector on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Apr 5 2022, 3:44 PM
nilima_mahakur28 claimed this task.Mar 4 2023, 5:40 PM
Aklapper removed nilima_mahakur28 as the assignee of this task.Jul 4 2023, 9:16 AM
Aklapper added a subscriber: nilima_mahakur28.

@nilima_mahakur28: I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL