AWB should not modify content between <chem> tags.
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	SalixAlba
	Nov 29 2021, 6:54 AM

Description

In this edit https://en.wikipedia.org/w/index.php?title=Barium_chromate&diff=1057528494&oldid=1037585482

User:MinusBot bot applied some AWB general fixes. These had the side effect of changing code inside a <chem> tag, in particular it changed

<chem>\mathsf{{Ba(OH)2} + K2CrO4 -> BaCrO4(v) + 2KOH}</chem>

into

<chem>\mathsf{{Ba(OH)2}} + K2CrO4 -> BaCrO4(v) + 2KOH}</chem>

turning a } into a }}. This broke the chem formula.

Chem blocks <chem> should be treated the same as <math> and no changes made inside the block. <ce> is a synonym for <chem> and should also be skipped.

Event Timeline

SalixAlba created this task.Nov 29 2021, 6:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 29 2021, 6:54 AM

Working on a fix

@Reedy @Aklapper or others-- This is my first change and I need some guidance on how to proceed.

I have the source code running and my change is tested. Does my sourceforge user "scehardt" need permissions to commit?

Once I do commit, what should the status of this task be? Any next steps to request code review, build, etc?

Thanks

Hi and thanks for your interest! I unfortunately have no idea about Sourceforge and how the AWB folks are using it...

For reference: https://en.wikipedia.org/wiki/Help:Displaying_a_formula#Chemistry

<math chem> is relevant in addition to <chem> and <ce>

rev 12536 Treat <chem> tags like <math> tags

@Rjwilmsi I'm confused about what's going on here - why did you take over an in-progress task with no comment? Is this project closed to (or not interested in) new contributors?

@SCEhardt Project welcomes new contributors. For AWB we have no particular standards as to how to use phabricator other than as where tickets get raised. For this ticket I saw mentions of new tickets on the AWB talk page so had a spin through those I agreed were problems and I could resolve.

@Rjwilmsi ok, fair enough.

If you have a moment, could you address my question about how to get started as a new contributor? Probably best to discuss over here instead of on this ticket: https://en.wikipedia.org/wiki/Wikipedia_talk:AutoWikiBrowser#Help_contributing_to_the_source_code

AWB should not modify content between <chem> tags.Closed, ResolvedPublicBUG REPORTActions

Description

Event Timeline

AWB should not modify content between <chem> tags.
Closed, ResolvedPublicBUG REPORT
Actions