Page MenuHomePhabricator
Create Task
Maniphest T296624

SX Dashboard: Suggestions are not fetched when canceling translation with preselected page
Closed, ResolvedPublicBUG REPORT
Actions

Description

As shown in the screencast below, when user visits a Section Translation URL with pre-selected page title (e.g. https://test.m.wikipedia.org/w/index.php?title=Special:ContentTranslation&page=Advent%20wreath&from=en&to=ar&sx=true), and then clicks on the close icon inside "Confirm translation" step, the page and section suggestions are not being filled inside the dashboard.

Additionally, the pre-selected suggestion is always shown inside the section suggestion list, even if the target page doesn't exist (and thus it belongs to the page suggestions).

Screen Recording 2021-11-29 at 1.28.10 PM.gif (820×388 px, 2 MB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/ContentTranslationmaster+2 -2CX3 Build 0.1.0+20211210
mediawiki/extensions/ContentTranslationmaster+74 -14SX: Fix suggestion loading after canceling preselected translation
Customize query in gerrit

Related Objects
Search...

Event Timeline

ngkountas created this task.Nov 29 2021, 11:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 29 2021, 11:35 AM
ngkountas claimed this task.Nov 29 2021, 11:35 AM
ngkountas moved this task from Priority: SX Adoption to In Progress on the Language-Team (Language-2021-October-December) board.
gerritbot added a comment.Nov 29 2021, 11:54 AM

Change 742442 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Fix suggestion loading after canceling preselected translation

https://gerrit.wikimedia.org/r/742442

gerritbot added a project: Patch-For-Review.Nov 29 2021, 11:54 AM
ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2021-October-December) board.Nov 29 2021, 11:57 AM
Pginer-WMF triaged this task as High priority.Nov 29 2021, 12:35 PM
Pginer-WMF added a parent task: T241591: Section Translation: expose suggested sections.
gerritbot added a comment.Nov 30 2021, 11:52 AM

Change 742442 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Fix suggestion loading after canceling preselected translation

https://gerrit.wikimedia.org/r/742442

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 30 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 30 2021, 12:10 PM
gerritbot added a comment.Dec 10 2021, 6:59 PM

Change 745934 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211210

https://gerrit.wikimedia.org/r/745934

gerritbot added a project: Patch-For-Review.Dec 10 2021, 6:59 PM
gerritbot added a comment.Dec 13 2021, 8:21 AM

Change 745934 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211210

https://gerrit.wikimedia.org/r/745934

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.13; 2021-12-13); removed MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 13 2021, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 13 2021, 9:11 AM
Pginer-WMF edited projects, added Language-Team (Language-2022-January-March); removed Language-Team (Language-2021-October-December).Jan 10 2022, 3:22 PM
Pginer-WMF moved this task from Quarter Backlog to In Review on the Language-Team (Language-2022-January-March) board.
ngkountas moved this task from In Review to Needs QA on the Language-Team (Language-2022-January-March) board.Jan 11 2022, 2:10 PM
Pginer-WMF added a subscriber: Pginer-WMF.Jan 14 2022, 10:09 AM

The main issue described seems fixed. However, I noticed that taping on "refresh" only updates the "articles to expand" part but keeps the same list for "articles to create".

After multiple refresh actions both lists get stuck, but that seems to be more of a general issue and a separate ticket needs to be created.

@ngkountas, should the first issue be addressed on this ticket or maybe on the new one?

Pginer-WMF moved this task from Backlog to Entry points on the SectionTranslation board.Jan 20 2022, 4:32 PM
Pginer-WMF closed this task as Resolved.Jan 24 2022, 10:42 AM
Pginer-WMF mentioned this in T299891: Refresh option stops working after several uses.
Pginer-WMF moved this task from Needs QA to Done on the Language-Team (Language-2022-January-March) board.

I captured the notes in a follow-up ticket: T299891: Refresh option stops working after several uses

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL