Page MenuHomePhabricator

Check Local Keys and Supernumerary Keys in BUILTIN_FUNCTION_CALL_VALIDATOR_
Closed, InvalidPublic

Description

function-orchestrator code can be found at https://gerrit.wikimedia.org/g/mediawiki/services/function-orchestrator

Look for this task's ID in src/builtins.js

The builtin function call validator does not account for local keys (e.g. K3) or throw errors when an extra key is supplied (e.g. when a function declares keys [Z1000K1, Z1000K2] but additionally receives Z1000K3). Add code support and tests for these cases.

Event Timeline

Aklapper added a subscriber: Aklapper.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor. Given the non-existing task description and the lack of information where to find the codebase I'm removing the good first task tag. Please add details what exactly has to happen where and how for a new contributor, and then add back the good first task project tag. Thanks a lot in advance.

Jdforrester-WMF renamed this task from Check Local Keys and Supererogatory Keys in BUILTIN_FUNCTION_CALL_VALIDATOR_ to Check Local Keys and Supernumerary Keys in BUILTIN_FUNCTION_CALL_VALIDATOR_.Dec 1 2021, 5:07 PM
Jdforrester-WMF closed this task as Invalid.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

We're not going to worry about this in the static analysis, only in run-time.