Page MenuHomePhabricator
Create Task
Maniphest T296676

Propagate Validator Errors as Z5s
Closed, ResolvedPublic
Actions

Description

function-orchestrator code can be found at https://gerrit.wikimedia.org/g/mediawiki/services/function-orchestrator

Look for T296676 under src/.

Currently, when validation in the orchestrator fails, it surfaces a stock error. This error should be the Z5 produced by the validator's error formatter. The errorFormatter can be found under function-schemata/javascript/src/errorFormatter.js.

For more context, consult the AJV documentation on errors.

Ideally, we would surface only the errors whose instancePath is longest, as these are likely to be the "real" errors. This work has been de-scoped from this task and moved to T301494: Filter validation errors to avoid over-loading the user with too many overlapping/duplicative errors instead.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

cmassaro created this task.Nov 29 2021, 8:48 PM
cmassaro updated the task description. (Show Details)Nov 30 2021, 6:32 PM
DVrandecic moved this task from To triage to Phase η – Generic types on the Abstract Wikipedia team board.Dec 1 2021, 5:19 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
DVrandecic moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Dec 7 2021, 5:42 PM
DVrandecic triaged this task as Low priority.Dec 8 2021, 11:33 PM
DVrandecic added a parent task: T288123: Re-work Z5/Error model and handling.Jan 26 2022, 10:24 PM
DMartin-WMF subscribed.Jan 27 2022, 7:21 PM

Related to https://phabricator.wikimedia.org/T282820

DMartin-WMF claimed this task.Jan 31 2022, 6:16 AM
DMartin-WMF moved this task from Ready to do to In progress on the Abstract Wikipedia team (Phase η – Generic types) board.Jan 31 2022, 7:37 PM
Jdforrester-WMF mentioned this in T301494: Filter validation errors to avoid over-loading the user with too many overlapping/duplicative errors.Feb 10 2022, 5:45 PM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Feb 16 2022, 5:32 AM

Change 762984 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-schemata@master] Create 2 error types for type validation failures

https://gerrit.wikimedia.org/r/762984

gerritbot added a project: Patch-For-Review.Feb 16 2022, 5:32 AM
gerritbot added a comment.Feb 18 2022, 12:19 PM

Change 762984 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Create 2 error types for type validation failures

https://gerrit.wikimedia.org/r/762984

DMartin-WMF mentioned this in rMSFS0de4d5b840bd: Create 2 error types for type validation failures.Feb 18 2022, 12:20 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 18 2022, 1:10 PM
gerritbot added a comment.Feb 22 2022, 3:41 PM

Change 764807 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (650770f)

https://gerrit.wikimedia.org/r/764807

gerritbot added a project: Patch-For-Review.Feb 22 2022, 3:41 PM
gerritbot added a comment.Feb 22 2022, 3:50 PM

Change 764807 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (650770f)

https://gerrit.wikimedia.org/r/764807

• JKieserman mentioned this in rMSFO1c384e10134d: Update function-schemata sub-module to HEAD (650770f).Feb 22 2022, 3:50 PM
gerritbot added a comment.Feb 22 2022, 3:52 PM

Change 764812 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (650770f)

https://gerrit.wikimedia.org/r/764812

gerritbot added a comment.Feb 22 2022, 3:52 PM

Change 764813 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (650770f)

https://gerrit.wikimedia.org/r/764813

gerritbot added a comment.Feb 22 2022, 9:54 PM

Change 764812 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (650770f)

https://gerrit.wikimedia.org/r/764812

Jdforrester-WMF mentioned this in rMSFEb18b764ae441: Update function-schemata sub-module to HEAD (650770f).Feb 22 2022, 9:55 PM
gerritbot added a comment.Feb 23 2022, 4:00 PM

Change 765296 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-schemata@master] Add \"propagated error\" key to Z506, Z517, Z518

https://gerrit.wikimedia.org/r/765296

gerritbot added a comment.Feb 24 2022, 5:57 PM

Change 765296 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Add \"propagated error\" key to Z506, Z517, Z518

https://gerrit.wikimedia.org/r/765296

DMartin-WMF mentioned this in rMSFSe093a551fdce: Add "propagated error" key to Z506, Z517, Z518.Feb 24 2022, 5:59 PM
gerritbot added a comment.Feb 24 2022, 9:39 PM

Change 764813 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (650770f)

https://gerrit.wikimedia.org/r/764813

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 24 2022, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 24 2022, 10:10 PM
gerritbot added a comment.Feb 25 2022, 6:15 AM

Change 765674 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Propagate Validator Errors as Z5s in execute.js

https://gerrit.wikimedia.org/r/765674

gerritbot added a project: Patch-For-Review.Feb 25 2022, 6:15 AM
Jdforrester-WMF moved this task from In progress to Code Review on the Abstract Wikipedia team (Phase η – Generic types) board.Feb 25 2022, 3:51 PM
gerritbot added a comment.Mar 1 2022, 12:59 AM

Change 766886 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (a28d2df)

https://gerrit.wikimedia.org/r/766886

gerritbot added a comment.Mar 1 2022, 12:59 AM

Change 766887 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (a28d2df)

https://gerrit.wikimedia.org/r/766887

gerritbot added a comment.Mar 1 2022, 12:59 AM

Change 766888 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (a28d2df)

https://gerrit.wikimedia.org/r/766888

gerritbot added a comment.Mar 1 2022, 3:34 PM

Change 767201 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (afc9127)

https://gerrit.wikimedia.org/r/767201

gerritbot added a comment.Mar 1 2022, 3:41 PM

Change 767204 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (f615309)

https://gerrit.wikimedia.org/r/767204

gerritbot added a comment.Mar 1 2022, 3:46 PM

Change 766886 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (a28d2df)

https://gerrit.wikimedia.org/r/766886

gerritbot added a comment.Mar 1 2022, 4:00 PM

Change 766888 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (a28d2df)

https://gerrit.wikimedia.org/r/766888

gerritbot added a comment.Mar 1 2022, 4:00 PM

Change 766887 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (a28d2df)

https://gerrit.wikimedia.org/r/766887

Jdforrester-WMF mentioned this in rMSFO06c241d4496c: Update function-schemata sub-module to HEAD (a28d2df).Mar 1 2022, 4:01 PM
gerritbot added a comment.Mar 1 2022, 4:02 PM

Change 767201 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (afc9127)

Reason:

https://gerrit.wikimedia.org/r/767201

gerritbot added a comment.Mar 1 2022, 4:02 PM

Change 767204 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (f615309)

Reason:

https://gerrit.wikimedia.org/r/767204

Jdforrester-WMF mentioned this in rMSFEc008ccbd6a6f: Update function-schemata sub-module to HEAD (a28d2df).Mar 1 2022, 4:02 PM
Jdforrester-WMF moved this task from Code Review to Incoming on the Abstract Wikipedia team (Phase η – Generic types) board.Mar 1 2022, 8:26 PM
Jdforrester-WMF moved this task from Incoming to Code Review on the Abstract Wikipedia team (Phase η – Generic types) board.
gerritbot added a comment.Mar 3 2022, 3:10 AM

Change 767614 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Change {Scope} to {Frame} in execute.js

https://gerrit.wikimedia.org/r/767614

DMartin-WMF changed the task status from Open to In Progress.Mar 3 2022, 4:25 AM
gerritbot added a comment.Mar 3 2022, 1:09 PM

Change 767614 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Change {Scope} to {Frame} in execute.js

https://gerrit.wikimedia.org/r/767614

DMartin-WMF mentioned this in rMSFO53ad52c7f582: Change {Scope} to {Frame} in execute.js.Mar 3 2022, 1:10 PM
gerritbot added a comment.Mar 4 2022, 3:11 PM

Change 765674 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Propagate Validator Errors as Z5s in execute.js

https://gerrit.wikimedia.org/r/765674

Jdforrester-WMF mentioned this in rMSFO023f0b81abc8: Propagate Validator Errors as Z5s in execute.js.Mar 4 2022, 3:12 PM
Jdforrester-WMF moved this task from Code Review to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Mar 4 2022, 3:48 PM
DVrandecic closed this task as Resolved.Mar 8 2022, 5:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL