Page MenuHomePhabricator

Builtin Implementation Identities Should Be Z6K1s
Open, In Progress, HighPublic

Description

function-orchestrator code can be found at https://gerrit.wikimedia.org/g/mediawiki/services/function-orchestrator

src/implementation.js (line 56, or search for T296682 within the file)

Find and fix any cases within the code base where a builtin implementation's identity is a ZReference (Z9) instead of a ZString (Z6).

An Implementation (Z14) is builtin if Z14K4 is populated. Z14K4 should always be a ZString (Z6).

Event Timeline

Aklapper added a subscriber: Aklapper.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor. Given the non-existing task description and the lack of information where to find the codebase I'm removing the good first task tag. Please add details what exactly has to happen where and how for a new contributor, and then add back the good first task project tag. Thanks a lot in advance.

This comment was removed by cmassaro.
DVrandecic triaged this task as Medium priority.Dec 8 2021, 11:33 PM
DVrandecic raised the priority of this task from Medium to High.

Change 745968 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Ensure all built-in implementation identities employ Z6/string objects

https://gerrit.wikimedia.org/r/745968

Change 745968 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Ensure all built-in implementation identities employ Z6/string objects

https://gerrit.wikimedia.org/r/745968