Page MenuHomePhabricator
Create Task
Maniphest T296688

[wmf.9-regression] oo-ui-image-error icon placed too close to the difficulty level label
Closed, ResolvedPublic
Actions

Assigned To
Sgs
Authored By
Etonkovidova
Nov 29 2021, 10:15 PM
Tags
Referenced Files
F34851349: Screen Shot 2021-12-06 at 5.29.02 PM.png
Dec 7 2021, 1:30 AM
F34790067: Screen Shot 2021-11-29 at 2.04.53 PM.png
Nov 29 2021, 10:15 PM
F34790065: Screen Shot 2021-11-29 at 2.07.36 PM.png
Nov 29 2021, 10:15 PM
F34790063: Screen Shot 2021-11-29 at 2.06.46 PM.png
Nov 29 2021, 10:15 PM
Subscribers
Aklapper
Etonkovidova
kostajh
• mewoph
RHo
Sgs
Tgr

Description

  1. On Special:Homepage go Select types of edits filter.
  2. Deselect all filters - the warning message "Select at least one type of edit" will appear with the icon placed too close to the header "Easy":
Screen Shot 2021-11-29 at 2.06.46 PM.png (1×1 px, 200 KB)
Screen Shot 2021-11-29 at 2.07.36 PM.png (1×776 px, 166 KB)
Screen Shot 2021-11-29 at 2.04.53 PM.png (1×1 px, 133 KB)

Spec: https://www.figma.com/file/Pgo6fPGaDDiqXWGfMI8oiF/Growth---features?node-id=901%3A81158

Details

SubjectRepoBranchLines +/-
Suggested edits: increase vertical spacing for error message labelmediawiki/extensions/GrowthExperimentsmaster+4 -0
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Nov 29 2021, 10:15 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 29 2021, 10:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Nov 29 2021, 10:16 PM
• mewoph added a comment.Nov 29 2021, 10:59 PM

Hi @Etonkovidova, do you have a screenshot of what this error state used to look like before (or even better, the specifications)? I can't find the spec for this particular state and I don't see anything in the change history for this particular file.

Etonkovidova added a subscriber: Sgs.Nov 30 2021, 12:56 AM
Etonkovidova added a comment.Nov 30 2021, 3:40 PM
In T296688#7535952, @mewoph wrote:

Hi @Etonkovidova, do you have a screenshot of what this error state used to look like before (or even better, the specifications)? I can't find the spec for this particular state and I don't see anything in the change history for this particular file.

@mewoph - you're right, probably I shouldn't file it as a regression. I don't have the before screenshots. And also I couldn't find the specs on Figma.

Pinging @RHo for the input on whether it's a regression issue and, if so, should it be addressed or not.

RHo added a comment.Nov 30 2021, 4:26 PM
In T296688#7537809, @Etonkovidova wrote:
In T296688#7535952, @mewoph wrote:

Hi @Etonkovidova, do you have a screenshot of what this error state used to look like before (or even better, the specifications)? I can't find the spec for this particular state and I don't see anything in the change history for this particular file.

@mewoph - you're right, probably I shouldn't file it as a regression. I don't have the before screenshots. And also I couldn't find the specs on Figma.

Pinging @RHo for the input on whether it's a regression issue and, if so, should it be addressed or not.

Hiya, I believe it is either a regression or oversight that should be fixed as it is definitely too close – as compared to the spacing in this initial version mock https://wikimedia.invisionapp.com/console/share/FUTVMSLV24X/383484896.
I've recreated the intended spacing (16px) for the Figma spec here in case that helps:
https://www.figma.com/file/Pgo6fPGaDDiqXWGfMI8oiF/Growth---features?node-id=901%3A81158

• mewoph updated the task description. (Show Details)Nov 30 2021, 5:07 PM
Sgs claimed this task.Nov 30 2021, 5:10 PM
gerritbot added a comment.Dec 2 2021, 11:38 AM

Change 743139 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: increase vertical spacing for error message label

https://gerrit.wikimedia.org/r/743139

gerritbot added a project: Patch-For-Review.Dec 2 2021, 11:38 AM
Sgs moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 2 2021, 11:39 AM
Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
PatchDemoBot added a comment.Dec 2 2021, 1:02 PM

Test wiki created on Patch demo by KHarlan (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/fa0dd7365a/w/

Sgs added a comment.Dec 2 2021, 1:03 PM

I couldn't tell if it was a regression or not, if it was one it was from more than 2 months ago. I pushed a patch for it.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 3 2021, 1:45 PM
gerritbot added a comment.Dec 3 2021, 2:08 PM

Change 743139 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: increase vertical spacing for error message label

https://gerrit.wikimedia.org/r/743139

Maintenance_bot removed a project: Patch-For-Review.Dec 3 2021, 2:10 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 3 2021, 3:00 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 7 2021, 1:30 AM

Checked on enwiki betalabs - the fix is in place.

Screen Shot 2021-12-06 at 5.29.02 PM.png (1×1 px, 218 KB)

Etonkovidova closed this task as Resolved.Dec 7 2021, 10:27 PM
PatchDemoBot added a comment.Jan 15 2022, 11:07 AM

Test wiki on Patch demo by KHarlan (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/fa0dd7365a/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL