List of steps to reproduce (step by step, including full links if applicable):
- Open an Add Image task in Minerva on desktop, with a user who does not have the "always skip onboarding" user preference
- When onboarding opens, press Esc
What happens?:
The keypress event is passed through to VisualEditor, which exits into read mode. The dialog stays open so the change is hard to notice, which makes the behavior even more confusing.
What should have happened instead?:
Capture the keypress and close the dialog.
Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
Chrome.
This doesn't affect other skins (desktop mode) where the Esc key is handled properly and the dialog is closed; nor real mobile, as there's no Esc key. People do use Minerva on desktop, though.