Page MenuHomePhabricator
Create Task
Maniphest T296730

Broken VE template dialog styling in old sidebar mode
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

The dynamic actions like deletion render poorly. Not sure when this regression was introduced.

image.png (505×733 px, 72 KB)

Details

SubjectRepoBranchLines +/-
Fix action icons breaking into multiple lines on narrow screensmediawiki/extensions/VisualEditormaster+0 -1
Customize query in gerrit

Event Timeline

awight created this task.Nov 30 2021, 1:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2021, 1:36 PM
awight changed the subtype of this task from "Task" to "Bug Report".Nov 30 2021, 1:36 PM
thiemowmde subscribed.Nov 30 2021, 2:45 PM

@awight, I fail to reproduce this. Can you provide more information?

WMDE-Fisch claimed this task.Dec 1 2021, 12:10 PM
WMDE-Fisch subscribed.
In T296730#7537572, @thiemowmde wrote:

@awight, I fail to reproduce this. Can you provide more information?

I can reproduce this on a narrow screen. Not sure if it was an issue already before though, will look into it briefly.

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-11-24 board.Dec 1 2021, 12:10 PM
WMDE-Fisch moved this task from Doing to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2021-11-24 board.Dec 1 2021, 12:19 PM

Issue is already present way before our changes to that codebase. I would not prioritize fixing it in any way. Ideally it's gone when the 'old' sidebar is replaced.

WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Dec 1 2021, 12:19 PM
gerritbot added a comment.Dec 1 2021, 1:57 PM

Change 742962 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix action icons breaking into multiple lines on narrow screens

https://gerrit.wikimedia.org/r/742962

gerritbot added a project: Patch-For-Review.Dec 1 2021, 1:57 PM
thiemowmde claimed this task.Dec 1 2021, 1:58 PM
thiemowmde moved this task from Watching / Epic / Stalled to Tech Review on the WMDE-TechWish-Sprint-2021-11-24 board.
thiemowmde set the point value for this task to 2.
gerritbot added a comment.Dec 1 2021, 4:04 PM

Change 742962 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix action icons breaking into multiple lines on narrow screens

https://gerrit.wikimedia.org/r/742962

Maintenance_bot removed a project: Patch-For-Review.Dec 1 2021, 4:10 PM
WMDE-Fisch moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2021-11-24 board.Dec 1 2021, 4:17 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 1 2021, 5:00 PM
WMDE-Fisch closed this task as Resolved.Dec 7 2021, 9:26 AM
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-11-24 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL