Maniphest T296827

remove getZObjectAsJsonByZID and refactor the code to use existing getZObjectAsJsonById
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	SimoneThisDot
	Dec 1 2021, 11:45 AM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Description

Currently the code has two very similar methods:

getZObjectAsJsonByZID
getZObjectAsJsonById

The outcome of this ticket is to remove the first one "getZObjectAsJsonByZID" because its implementation is not very clean and it also fragile as it expect an object to just be preset once within the zObject (and this is not always going to be the case).

Details

	Subject	Repo	Branch	Lines +/-
	remove getZObjectAsJsonByZID	mediawiki/extensions/WikiLambda	master	+240 -254

Customize query in gerrit

Event Timeline

SimoneThisDot created this task.Dec 1 2021, 11:45 AM

DVrandecic moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Dec 1 2021, 5:30 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.

SimoneThisDot claimed this task.Dec 2 2021, 10:16 PM

Change 744001 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/WikiLambda@master] remove getZObjectAsJsonByZID

https://gerrit.wikimedia.org/r/744001

gerritbot added a project: Patch-For-Review.Dec 6 2021, 2:22 PM

Change 744001 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] remove getZObjectAsJsonByZID

https://gerrit.wikimedia.org/r/744001

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 7 2021, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 7 2021, 3:10 PM

Thank you!