Page MenuHomePhabricator

Update EmbedPlayer to remove the use of Navigator.userAgent
Closed, DeclinedPublic

Description

Due to future changes highlighted in the parent task, we have to update our code to make sure that deprecated methods will no longer be used.

As highlighted by this search filter: code filter, the embed player uses navigator.userAgent that will be removed in future version of chrome.

The impact of this deprecation to the client is unknown and investigation is required as part of this ticket

Acceptance criteria

  • Investigate the impact of the method deprecation
  • Update the code using the futurly deprecated navigator.userAgent from mwembed

Event Timeline

Note that EmbedPlayer is EOL and will be removed after we finish up the last cleanups on videojs mode. We can consider it deprecated in its entirety.

@brion Am I ok to close the task then as not applicable anymore? Any chance you can link a ticket or anything that link to the player EOL?

Closing as per the above. @brion please reopen if necessary, thanks.