Delete Unused `function_call` Schema and Accompanying Tests
Closed, ResolvedPublic
Actions

Description

function-schemata code can be found at https://gerrit.wikimedia.org/g/mediawiki/services/function-schemata

data/function_call/* hasn't ever been used and can be deleted.
Likewise, tests which use files from that directory under javascript/test can be deleted.

Details

Project	Branch	Lines +/-	Subject
mediawiki/services/function-evaluator	master	+1 -1	Update function-schemata sub-module to HEAD (c2667cb)
mediawiki/extensions/WikiLambda	master	+1 -1	Update function-schemata sub-module to HEAD (c2667cb)
mediawiki/services/function-orchestrator	master	+2 -2	Update function-schemata sub-module to HEAD (c2667cb)
mediawiki/services/function-schemata	master	+0 -168	Delete unused `function_call` schema and accompanying tests

Customize query in gerrit

Related Objects

Mentioned In: rMSFE241f1bdfa473: Update function-schemata sub-module to HEAD (c2667cb)
rMSFO6b65236e9fb1: Update function-schemata sub-module to HEAD (c2667cb)
rMSFS30cb457a8576: Delete unused `function_call` schema and accompanying tests

Event Timeline

cmassaro created this task.Dec 1 2021, 1:07 PM

DVrandecic moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Dec 1 2021, 5:30 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.

can you tell what i have to do on this issue. is we have to delete (data/function_call/*) this file ?

Gaurav_436310 claimed this task.Jan 4 2022, 7:47 PM

Please review my pull request. (This is my first pull request.)
https://gerrit.wikimedia.org/r/q/I874cfb4a5a6f6a3476cf3636b3e14e9e00bc9a72

Jdforrester-WMF edited projects, added Abstract Wikipedia Fix-It tasks; removed good first task.Jan 18 2022, 7:53 PM

Change 751511 had a related patch set uploaded (by Jforrester; author: Gaurav k):

[mediawiki/services/function-schemata@master] Delete unused `function_call` schema and accompanying tests

https://gerrit.wikimedia.org/r/751511

gerritbot added a project: Patch-For-Review.Jan 24 2022, 6:16 PM

Change 751511 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Delete unused `function_call` schema and accompanying tests

https://gerrit.wikimedia.org/r/751511

Jdforrester-WMF closed this task as Resolved.Jan 24 2022, 6:21 PM

Jdforrester-WMF mentioned this in rMSFS30cb457a8576: Delete unused `function_call` schema and accompanying tests.Jan 24 2022, 6:26 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2022, 7:10 PM

Change 757045 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (c2667cb)

https://gerrit.wikimedia.org/r/757045

gerritbot added a project: Patch-For-Review.Jan 25 2022, 5:57 PM

Change 757045 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (c2667cb)

https://gerrit.wikimedia.org/r/757045

cmassaro mentioned this in rMSFO6b65236e9fb1: Update function-schemata sub-module to HEAD (c2667cb).Jan 25 2022, 6:04 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 25 2022, 6:10 PM

Change 757082 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (c2667cb)

https://gerrit.wikimedia.org/r/757082

Change 757083 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (c2667cb)

https://gerrit.wikimedia.org/r/757083

Change 757083 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (c2667cb)

https://gerrit.wikimedia.org/r/757083

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 27 2022, 2:00 PM

Change 759337 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (096fd3b)

https://gerrit.wikimedia.org/r/759337

Change 757082 merged by jenkins-bot: