Page MenuHomePhabricator
Create Task
Maniphest T296842

Tighten Guarantees in `GenericSchema.validateStatus`
Open, LowPublic
Actions

Description

function-schemata code can be found at https://gerrit.wikimedia.org/g/mediawiki/services/function-schemata

validateStatus (look for this task's ID in javascript/src/schema.js) should

  • fail when there is an unexpected key
  • signal which key failed if a sub-validator was the culprit
  • not fail if an "optional" key is absent

Details

SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (194e4da)mediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (194e4da)mediawiki/tools/wikilambda-climaster+1 -1
Update function-schemata sub-module to HEAD (194e4da)mediawiki/services/function-evaluatormaster+1 -1
Update function-schemata sub-module to HEAD (194e4da)mediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (194e4da)mediawiki/services/function-orchestratormaster+1 -1
Fail to validate when unwelcome keys are present.mediawiki/services/function-schematamaster+124 -126
Customize query in gerrit

Related Objects

Event Timeline

cmassaro created this task.Dec 1 2021, 1:29 PM
cmassaro added a project: function-schemata.Dec 1 2021, 3:44 PM
DVrandecic moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Dec 1 2021, 5:31 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.
cmassaro mentioned this in T314994: Validators Created from User-Defined Types Are Sometimes Null.Aug 15 2022, 1:48 PM
gerritbot added a comment.Aug 15 2022, 4:13 PM

Change 823163 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Fail to validate when unwelcome keys are present.

https://gerrit.wikimedia.org/r/823163

gerritbot added a project: Patch-For-Review.Aug 15 2022, 4:13 PM
gerritbot added a comment.Aug 15 2022, 5:33 PM

Change 823163 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Fail to validate when unwelcome keys are present.

https://gerrit.wikimedia.org/r/823163

cmassaro mentioned this in rMSFSb2565e6bb9d3: Fail to validate when unwelcome keys are present..Aug 15 2022, 5:34 PM
gerritbot added a comment.Aug 15 2022, 5:34 PM

Change 823189 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823189

gerritbot added a comment.Aug 15 2022, 5:34 PM

Change 823190 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823190

gerritbot added a comment.Aug 15 2022, 5:34 PM

Change 823191 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823191

gerritbot added a comment.Aug 15 2022, 5:34 PM

Change 823192 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823192

gerritbot added a comment.Aug 15 2022, 5:42 PM

Change 823194 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823194

gerritbot added a comment.Aug 15 2022, 5:43 PM

Change 823194 abandoned by Cory Massaro:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (194e4da)

Reason:

https://gerrit.wikimedia.org/r/823194

gerritbot added a comment.Aug 15 2022, 5:46 PM

Change 823191 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823191

Jdforrester-WMF mentioned this in rMSFO0fd0e9eeb62f: Update function-schemata sub-module to HEAD (194e4da).Aug 15 2022, 5:47 PM
gerritbot added a comment.Aug 15 2022, 5:48 PM

Change 823190 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823190

Jdforrester-WMF mentioned this in rMSFE9b80d0d34b71: Update function-schemata sub-module to HEAD (194e4da).Aug 15 2022, 6:04 PM
gerritbot added a comment.Aug 16 2022, 2:01 PM

Change 823189 merged by jenkins-bot:

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823189

Jdforrester-WMF mentioned this in rMTWCd3303c3b5191: Update function-schemata sub-module to HEAD (194e4da).Aug 16 2022, 2:02 PM
gerritbot added a comment.Aug 16 2022, 2:16 PM

Change 823192 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823192

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2022, 2:29 PM
Jdforrester-WMF moved this task from Incoming to Better before launch on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:29 PM
Jdforrester-WMF mentioned this in rMSFS558872d04bb4: schemaTest: Drop outdated TODO, now TODONE.Jan 24 2023, 3:31 PM
Jdforrester-WMF triaged this task as Low priority.Mar 24 2023, 1:17 AM
Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: After launch on the Abstract Wikipedia team board.Jun 16 2023, 8:30 AM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).
Jdforrester-WMF moved this task from To triage: After launch to No current plans / External on the Abstract Wikipedia team board.Aug 31 2023, 4:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL