Same as bug 27611:
Use field ipb_by_text of table ipblocks instead of a join with the user table to get the "blocker_name".
Thanks.
Version: 1.18.x
Severity: enhancement
Same as bug 27611:
Use field ipb_by_text of table ipblocks instead of a join with the user table to get the "blocker_name".
Thanks.
Version: 1.18.x
Severity: enhancement
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Catrope | T29688 Simplify queries to list user block information | |||
Invalid | None | T29613 add a population script for ipb_by_text to the updater |
I was thinking I'd already done this one, slightly confusing
if ( $fld_blockinfo ) { $this->addTables( 'ipblocks' ); $this->addTables( 'user', 'u2' ); $u2 = $this->getAliasedName( 'user', 'u2' ); $this->addJoinConds( array( 'ipblocks' => array( 'LEFT JOIN', 'ipb_user=u1.user_id' ), $u2 => array( 'LEFT JOIN', 'ipb_by=u2.user_id' ) ) ); $this->addFields( array( 'ipb_reason', 'u2.user_name AS blocker_name' ) ); }
Just a case of simplifying that, and not having the 2nd join of the user table in :)
Also for list=users&usprop=blockinfo.
Thanks.
Done both in r82739, some simplfication in r82740
Also in r82739, I've exposed the block expiry information on list=users, was already there in list=allusers