When you set the local exception for an option the label text still appears disabled
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Dec 2 2021, 10:26 AM

Description

What is the problem?

On Special:Preferences, when you check the local exception for a global option the text label is greyed out like it were disabled.

This affects a lot of user preferences. I think mostly options with checkboxes.

Steps to reproduce problem

Go to Special:GlobalPreferences
Make "Allow other users to email me" global
Go to Special:Preferences
Check the local exception for "Allow other users to email me"

Expected behavior: The label "Allow other users to email me" is in the normal text colour
Observed behavior: The label is greyed out

Environment

Wiki(s): https://en.wikipedia.beta.wmflabs.org MediaWiki 1.38.0-alpha (2682461) 07:22, 2 December 2021. GlobalPreferences 0.1.2 (e9ea9af) 05:41, 1 December 2021.

Screenshots (if applicable):

greyed_out_labels.png (355×798 px, 50 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Infuse the field layout instead of widgets, to set the state of labels properly	mediawiki/extensions/GlobalPreferences	master	+11 -17

Customize query in gerrit

Related Objects

Mentioned In: T296028: Unable to set a local override for some Global Preferences
Mentioned Here: T272302: Preference "Allow emails from brand-new users" can be changed locally even when global and with "set a local exception" off
rEGPRe9ea9af70cdd: Merge "Avoid using User::getOption"
rMW2682461394ee: Localisation updates from https://translatewiki.net.

Event Timeline

dom_walden created this task.Dec 2 2021, 10:26 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2021, 10:26 AM

dom_walden mentioned this in T296028: Unable to set a local override for some Global Preferences.Dec 2 2021, 10:31 AM

This can be reproduced on production wikis, it seems that we should infuse the field layout and use $layout.fieldWidget.setDisabled() to set the state like what hide-if mechanism do. I'm here to mention https://gerrit.wikimedia.org/r/c/683142 again, which can fix this... Can someone promote the code review? Anyway, I can write a simple fix for this bug.

Change 743024 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/GlobalPreferences@master] Infuse the field layout instead of widgets, to set the state of labels properly

https://gerrit.wikimedia.org/r/743024

gerritbot added a project: Patch-For-Review.Dec 2 2021, 11:29 AM

Oh, in that way we don't need either the special treat for checkMatrixWidget or the enumeration of dependencies!

Func claimed this task.Dec 2 2021, 11:49 AM

In T296924#7543286, @Func wrote:

This can be reproduced on production wikis, it seems that we should infuse the field layout and use $layout.fieldWidget.setDisabled() to set the state like what hide-if mechanism do. I'm here to mention https://gerrit.wikimedia.org/r/c/683142 again, which can fix this... Can someone promote the code review?

We have T272302 in our "Needs review" column and have prioritized it. Apologies for the long wait. We truly appreciate you volunteering your time!

In T296924#7545099, @MusikAnimal wrote:

We have T272302 in our "Needs review" column and have prioritized it. Apologies for the long wait. We truly appreciate you volunteering your time!

Thank you! ~~In fact after this patch came out, my major concern to promote the 'disable-if' method has been dissolved a lot since we don't need to enumerate dependencies now.~~

Stang merged a task: T297218: Unable to change local preference if global preference is set.Dec 7 2021, 5:00 PM

Stang subscribed.

Change 743024 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] Infuse the field layout instead of widgets, to set the state of labels properly

https://gerrit.wikimedia.org/r/743024

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 9 2021, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 9 2021, 4:10 PM

matmarex subscribed.Dec 9 2021, 4:23 PM

Func closed this task as Resolved.Feb 23 2022, 12:58 PM

Stang unsubscribed.Mar 27 2022, 7:06 PM