Page MenuHomePhabricator
Create Task
Maniphest T296974

Function pages display "object" or "array" instead of the name of the function, hides ZID
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

  • It first displays "Is empty (Z813)" as the title, but then replaces it with "object" and then "array"

What should have happened instead?:

  • the label and ZID should be displayed as the title of the page

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
Fresh install as of today, or on notwikilambda

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Function pages display "object" or "array" instead of the name of the function, hides ZIDmediawiki/extensions/WikiLambdamaster+25 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

DVrandecic created this task.Dec 2 2021, 11:10 PM
DVrandecic moved this task from To Triage to Phase η – Generic types on the Abstract Wikipedia team board.Dec 7 2021, 5:16 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
DVrandecic moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Dec 7 2021, 5:47 PM
Jdforrester-WMF added a parent task: T296880: Modify the title in real time while the user changes the name of the object.Dec 7 2021, 5:47 PM
Jdforrester-WMF added a parent task: T295446: Modify the title in real time while user change name of existing function.Dec 8 2021, 5:55 PM
Jdforrester-WMF removed a parent task: T296880: Modify the title in real time while the user changes the name of the object.
DVrandecic triaged this task as High priority.Dec 8 2021, 11:35 PM
Jdforrester-WMF subscribed.Dec 14 2021, 4:02 PM

From some quick debugging, this is set by updateEditFunctionPageTitle() being called with 'object' as the title to write via setZObjectValue(), which seems AFAICT to be called by addZFunctionCall() hard-coding the string 'object' into it. This shouldn't be called at all in readOnly mode, so I guess we could trivially just add an escape if that's true, but it's not clear to me what's setting it in the first place.

• AdesojiThisDot claimed this task.Dec 15 2021, 8:18 AM
• AdesojiThisDot changed the task status from Open to In Progress.Dec 15 2021, 8:42 AM
• AdesojiThisDot moved this task from Ready to do to In progress on the Abstract Wikipedia team (Phase η – Generic types) board.
gerritbot added a comment.Dec 15 2021, 8:56 AM

Change 747458 had a related patch set uploaded (by AdesojiThisDot; author: AdesojiThisDot):

[mediawiki/extensions/WikiLambda@master] Function pages display \"object\" or \"array\" instead of the name of the function, hides ZID

https://gerrit.wikimedia.org/r/747458

gerritbot added a project: Patch-For-Review.Dec 15 2021, 8:56 AM
gerritbot added a comment.Dec 15 2021, 9:34 AM

Change 747458 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Function pages display \"object\" or \"array\" instead of the name of the function, hides ZID

https://gerrit.wikimedia.org/r/747458

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 15 2021, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 15 2021, 10:10 AM
• AdesojiThisDot moved this task from In progress to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Dec 15 2021, 2:40 PM
Jdforrester-WMF added a comment.Dec 15 2021, 4:18 PM

Thank you!

DVrandecic closed this task as Resolved.Jan 11 2022, 5:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits