Page MenuHomePhabricator
Create Task
Maniphest T296999

Add search clicks to sticky header instrumentation
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
ovasileva
Dec 3 2021, 11:57 AM
Tags
Referenced Files
F34886500: Screen Shot 2021-12-16 at 6.43.11 AM.png
Dec 16 2021, 2:44 PM
F34886481: Screen Shot 2021-12-15 at 9.33.46 AM.png
Dec 16 2021, 2:26 PM
F34869925: Screen Shot 2021-12-09 at 7.10.23 AM.png
Dec 9 2021, 3:11 PM
F34857538: Screen Shot 2021-12-07 at 4.18.57 PM.png
Dec 7 2021, 11:35 PM
Subscribers
Aklapper
cjming
Edtadros
Jdlrobson
jwang
• nray
ovasileva

Description

Background

During the sticky header instrumentation QA T294639: Schema QA sticky header instrumentation, we noticed that clicks to the search bar are not currently instrumented. We would like to add these to the instrumentation.

Acceptance criteria

  • Add instrumentation that tracks clicks to the search bar within the sticky header

Developer notes

Adding the data-event-name attribute to the element

QA steps

  • On an article page where sticky header is enabled, click on the search icon in sticky header and note the event that gets logged:

Screen Shot 2021-12-07 at 4.18.57 PM.png (1×4 px, 2 MB)

QA Results - Beta

ACStatusDetails
1✅T296999#7559954

QA Results - Prod

ACStatusDetails
1✅T296999#7575292

Details

SubjectRepoBranchLines +/-
Add data-event-name attribute to sticky search icon.mediawiki/skins/Vectormaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

ovasileva created this task.Dec 3 2021, 11:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 3 2021, 11:58 AM
ovasileva triaged this task as High priority.Dec 3 2021, 11:58 AM
ovasileva added a project: Desktop Improvements (Vector 2022).
ovasileva added subscribers: jwang, Jdlrobson.
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Dec 3 2021, 5:27 PM
Jdlrobson updated the task description. (Show Details)
LGoto moved this task from Incoming to Sticky header on the Desktop Improvements (Vector 2022) board.Dec 6 2021, 6:43 PM
LGoto set the point value for this task to 2.Dec 6 2021, 6:46 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
• nray claimed this task.Dec 6 2021, 11:17 PM
• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
• nray removed • nray as the assignee of this task.Dec 6 2021, 11:46 PM
• nray moved this task from Doing to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
• nray subscribed.
cjming claimed this task.Dec 7 2021, 8:47 PM
cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Dec 7 2021, 11:22 PM

Change 744894 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Add data-event-name attribute to sticky search icon.

https://gerrit.wikimedia.org/r/744894

gerritbot added a project: Patch-For-Review.Dec 7 2021, 11:22 PM
cjming removed cjming as the assignee of this task.Dec 7 2021, 11:25 PM
cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming subscribed.
Jdlrobson assigned this task to Edtadros.Dec 7 2021, 11:32 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming updated the task description. (Show Details)Dec 7 2021, 11:35 PM
gerritbot added a comment.Dec 7 2021, 11:56 PM

Change 744894 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add data-event-name attribute to sticky search icon.

https://gerrit.wikimedia.org/r/744894

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 8 2021, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 8 2021, 12:10 AM
Edtadros added a comment.Dec 9 2021, 3:11 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: On an article page where sticky header is enabled, click on the search icon in sticky header and note the event that gets logged:

Screen Shot 2021-12-09 at 7.10.23 AM.png (1×874 px, 256 KB)

Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Dec 9 2021, 3:13 PM
Edtadros updated the task description. (Show Details)Dec 9 2021, 3:16 PM
Edtadros reassigned this task from Edtadros to ovasileva.EditedDec 16 2021, 2:26 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: On an article page where sticky header is enabled, click on the search icon in sticky header and note the event that gets logged:
Per discussion with @Jdlrobson, the sampling rate for search is very low so the best way to validate is through the db on hue.wikimedia.org. Below is a screenshot as well as the event that is returned from the query.

Screen Shot 2021-12-16 at 6.43.11 AM.png (974×888 px, 164 KB)

{
  "action": "click",
  "skin": "vector",
  "skinversion": 2,
  "name": "ui.vector-sticky-search-form.icon",
  "token": "9156a8b18d8f7a35d3ac",
  "issidebarcollapsed": false,
  "isanon": false,
  "editcountbucket": "100-999 edits"
}
Edtadros updated the task description. (Show Details)Dec 16 2021, 2:26 PM
ovasileva closed this task as Resolved.Jan 4 2022, 12:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL