Page MenuHomePhabricator

Auto-scroll should not act when the selected sentence is already in the viewport
Closed, ResolvedPublic

Description

Auto-scroll support in Section Translation (T273752) is helpful to keep the sentence to translate always visible. However, currently it acts also on sentences that are completely in the viewport. When tapping on one of those sentences, the viewport moves in an unexpected way. This is illustrated in the video below:

This ticket proposes to not apply auto-scroll to sentences that are completely inside the viewport already.

Note that for sentences that are partially shown in the viewport, the auto-scroll should be kept to help showing most of them inside the viewport. The video below shows examples where this happens which should still work like this once the issue described above gets fixed:

Event Timeline

Change 745928 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Disable auto-scroll when sentence already inside the viewport

https://gerrit.wikimedia.org/r/745928

Change 745928 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Disable auto-scroll when sentence already inside the viewport

https://gerrit.wikimedia.org/r/745928

Change 752530 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20220110

https://gerrit.wikimedia.org/r/752530

Change 752530 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20220110

https://gerrit.wikimedia.org/r/752530