Page MenuHomePhabricator

Unable to add multiple statements at once in Structured Data on Commons
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • on Beta, find a file with no statements yet, e.g. this one
  • switch to the “Structured data” tab
  • either select the “depicts” input, or click “add statement”, select an item-type property (e.g. P116), then select the value input
  • enter one value, e.g. Q11, and select it
  • enter a second value, e.g. Q12

What happens?:
Nothing. No search results are shown, the second value cannot be added.

What should have happened instead?:
There should be search results for the second value (Q12), and it should be possible to select a result in order to add a corresponding statement.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
WikibaseMediaInfo c07222c (not yet in production)

Additional information:
This regressed between 2021-12-01 and 2021-12-02.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Arnon2499 added a subscriber: 00590.

This appears to still be broken.
I assume I introduced this regression here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/742188
I'm reopening & will investigate - if anyone knows more about this and it should in fact be closed, please elaborate!

Change 743953 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/WikibaseMediaInfo@master] Renderer fix: only match nodes between DOM versions

https://gerrit.wikimedia.org/r/743953

Change 743953 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Renderer fix: only match nodes between DOM versions

https://gerrit.wikimedia.org/r/743953

Seems to work, the AC/DC browser tests turned green again :) thanks!

Seems to work, the AC/DC browser tests turned green again :) thanks!

You mentioned this task in T293953. Did the relevant fixes end up in the wmf/1.38.0-wmf.12 branch?

(As far as I’m concerned, this task can be closed, but I’ll leave that to the SDC team.)

I'll close this given that the author confirmed that their issue got resolved, and internal QA also flagged this in a separate ticket (T297171) that's still open.
Thanks for flagging this!