Page MenuHomePhabricator

ArticleViewTest::testViewOfOldRevisionFromCache fails when run on its own
Closed, ResolvedPublic

Description

php tests/phpunit/phpunit.php tests/phpunit/includes/page/ArticleViewTest.php --filter testViewOfOldRevisionFromCache

Using PHP 7.4.26
PHPUnit 8.5.21 by Sebastian Bergmann and contributors.

E                                                                   1 / 1 (100%)

Time: 2.18 seconds, Memory: 63.02 MB

There was 1 error:

1) ArticleViewTest::testViewOfOldRevisionFromCache
TypeError: Argument 1 passed to PageTranslationHooks::addLanguageLinks() must be an instance of Title, null given, called in /Users/kostajh/src/mediawiki/w/includes/HookContainer/HookContainer.php on line 338

/Users/kostajh/src/mediawiki/w/extensions/Translate/tag/PageTranslationHooks.php:575
/Users/kostajh/src/mediawiki/w/includes/HookContainer/HookContainer.php:338
/Users/kostajh/src/mediawiki/w/includes/HookContainer/HookContainer.php:137
/Users/kostajh/src/mediawiki/w/includes/HookContainer/HookRunner.php:2240
/Users/kostajh/src/mediawiki/w/includes/OutputPage.php:2010
/Users/kostajh/src/mediawiki/w/includes/OutputPage.php:2059
/Users/kostajh/src/mediawiki/w/includes/page/Article.php:804
/Users/kostajh/src/mediawiki/w/includes/page/Article.php:709
/Users/kostajh/src/mediawiki/w/includes/page/Article.php:517
/Users/kostajh/src/mediawiki/w/tests/phpunit/includes/page/ArticleViewTest.php:282
/Users/kostajh/src/mediawiki/w/tests/phpunit/MediaWikiIntegrationTestCase.php:456

Or with Translate extension disabled:

php tests/phpunit/phpunit.php tests/phpunit/includes/page/ArticleViewTest.php --filter testViewOfOldRevisionFromCache
Using PHP 7.4.26
PHPUnit 8.5.21 by Sebastian Bergmann and contributors.

E                                                                   1 / 1 (100%)

Time: 2.03 seconds, Memory: 61.00 MB

There was 1 error:

1) ArticleViewTest::testViewOfOldRevisionFromCache
Error: Call to a member function isMainPage() on null

/Users/kostajh/src/mediawiki/w/extensions/MobileFrontend/includes/MobileFrontendHooks.php:1011
/Users/kostajh/src/mediawiki/w/includes/HookContainer/HookContainer.php:338
/Users/kostajh/src/mediawiki/w/includes/HookContainer/HookContainer.php:137
/Users/kostajh/src/mediawiki/w/includes/HookContainer/HookRunner.php:2676
/Users/kostajh/src/mediawiki/w/includes/OutputPage.php:2011
/Users/kostajh/src/mediawiki/w/includes/OutputPage.php:2059
/Users/kostajh/src/mediawiki/w/includes/page/Article.php:804
/Users/kostajh/src/mediawiki/w/includes/page/Article.php:709
/Users/kostajh/src/mediawiki/w/includes/page/Article.php:517
/Users/kostajh/src/mediawiki/w/tests/phpunit/includes/page/ArticleViewTest.php:282
/Users/kostajh/src/mediawiki/w/tests/phpunit/MediaWikiIntegrationTestCase.php:456

Event Timeline

Change 743959 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] ArticleViewTest: Set wgTitle for test

https://gerrit.wikimedia.org/r/743959

Change 743959 merged by jenkins-bot:

[mediawiki/core@master] ArticleViewTest: Set wgTitle for test

https://gerrit.wikimedia.org/r/743959

Krinkle assigned this task to kostajh.
Krinkle added a project: Growth-Team.