Page MenuHomePhabricator

SkinMustacheTest::testGetTemplateData fails when run on its own
Closed, ResolvedPublic

Description

php tests/phpunit/phpunit.php --filter SkinMustacheTest::testGetTemplateData
Using PHP 7.4.26
PHPUnit 8.5.21 by Sebastian Bergmann and contributors.

E                                                                   1 / 1 (100%)

Time: 16.31 seconds, Memory: 789.52 MB

There was 1 error:

1) SkinMustacheTest::testGetTemplateData
TypeError: Argument 2 passed to MediaWiki\Extension\CiteThisPage\Hooks::shouldAddLink() must implement interface Config, null given, called in /Users/kostajh/src/mediawiki/w/extensions/CiteThisPage/includes/Hooks.php on line 34

/Users/kostajh/src/mediawiki/w/extensions/CiteThisPage/includes/Hooks.php:19
/Users/kostajh/src/mediawiki/w/extensions/CiteThisPage/includes/Hooks.php:34
/Users/kostajh/src/mediawiki/w/includes/HookContainer/HookContainer.php:160
/Users/kostajh/src/mediawiki/w/includes/HookContainer/HookRunner.php:3358
/Users/kostajh/src/mediawiki/w/includes/skins/Skin.php:1653
/Users/kostajh/src/mediawiki/w/includes/skins/SkinTemplate.php:732
/Users/kostajh/src/mediawiki/w/includes/skins/SkinTemplate.php:193
/Users/kostajh/src/mediawiki/w/includes/skins/SkinMustache.php:79
/Users/kostajh/src/mediawiki/w/tests/phpunit/includes/skins/SkinMustacheTest.php:103
/Users/kostajh/src/mediawiki/w/tests/phpunit/MediaWikiIntegrationTestCase.php:456
=== Logs generated by test case
[ActionFactory] [debug] {actionName} is being set in configuration rather than CORE_ACTIONS {"actionName":"view"}
[ActionFactory] [debug] {actionName} is being set in configuration rather than CORE_ACTIONS {"actionName":"view"}
===

ERRORS!
Tests: 1, Assertions: 0, Errors: 1.

Event Timeline

Change 743971 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/CiteThisPage@master] Hooks: Handle null case for title/config

https://gerrit.wikimedia.org/r/743971

Change 743972 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] phpunit: Set config for SkinMustacheTest

https://gerrit.wikimedia.org/r/743972

Change 743971 merged by jenkins-bot:

[mediawiki/extensions/CiteThisPage@master] Hooks: Handle null case for title/config

https://gerrit.wikimedia.org/r/743971

Change 743972 merged by jenkins-bot:

[mediawiki/core@master] phpunit: Set config for SkinMustacheTest

https://gerrit.wikimedia.org/r/743972

Krinkle assigned this task to kostajh.
Krinkle added a project: Growth-Team.