Page MenuHomePhabricator
Create Task
Maniphest T297105

Remove deprecated Function User::getEffectiveGroups
Closed, DuplicatePublic
Actions

Description

After Updating from MW 1.36 to 1.37 the following error occurs:

Use of User::getEffectiveGroups was deprecated in MediaWiki 1.35. [Called from MediaWiki\Extensions\Lockdown\Hooks::onGetUserPermissionsErrors in /var/www/html/extensions/Lockdown/src/Hooks.php at line 123] in /var/www/html/includes/debug/MWDebug.php on line 375

The Release Notes for MW 1.35 says:

The following methods of the User class are deprecated: getGroups, getGroupMemberships, getEffectiveGroups, getAutomaticGroups, addGroup, removeGroup, getFormerGroups, getAllGroups, getImplicitGroups, addAutopromoteOnceGroups. Use the new UserGroupManager service instead.

So the extensions seems to be not working anymore.

Event Timeline

Alaub81 created this task.Dec 6 2021, 12:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2021, 12:42 PM
Aklapper added a comment.Dec 6 2021, 1:08 PM

So the extensions seems to be not working anymore.

If it does not work anymore, then there is a different reason. (Deprecation does not mean removal.)

Aklapper renamed this task from Deprecated Function to Remove deprecated Function User::getEffectiveGroups.Dec 6 2021, 1:09 PM
Aklapper added a project: Technical-Debt.
Ckujau subscribed.Dec 6 2021, 1:27 PM
Umherirrender closed this task as a duplicate of T281871: extensions/Lockdown - Use UserGroupManager instead of User group methods.Dec 6 2021, 3:05 PM
daniel subscribed.Dec 6 2021, 3:06 PM
In T297105#7549552, @Aklapper wrote:

So the extensions seems to be not working anymore.

If it does not work anymore, then there is a different reason. (Deprecation does not mean removal.)

That is correct: in 1.37, the extension should still work, but log warnings. However, the method has been removed on the development branch now, and the extension will stop working in 1.38, unless the issue is fixed.

The deprecation message say to use UserGroupManager::getUserEffectiveGroups instead, so that would be the appropriate fix.

(Note: I'm the original author of the Lockdown extension, but I have not been maintaining it for a decade or so).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits