| Tulli0 | |
| Dec 7 2021, 1:25 PM |
| F34854921: Screenshot_20211207_142107.png | |
| Dec 7 2021, 1:25 PM |
| F34854947: patch_sql_error.patch | |
| Dec 7 2021, 1:25 PM |
I make a clear installation of the last wikimedia and the extension on a macchine with Postgresql DB
When I visit the special page Special:ApprovedRevs I received e sql error.
The order fields was not indicate in the sql extract.
I add these fields on the wiki/extensions/ApprovedRevs/includes/ApprovedRevs.php file
I attach a screen-shot of the error page and a patch file that work for me.
cc'ing @Yaron_Koren as the maintainer of ApprovedRevs for thoughts on the patch; IMO it looks straightforward enough and provided that it fixes PG and doesn't cause issues on other DBMSes, no reason to not merge it!
I missed this until now! Although it turns out that a patch essentially identical to this one was added to Approved Revs right around when this patch was created:
https://phabricator.wikimedia.org/rEARE609df7020028d8b862452e1c79844163cc64dfa5
So, I'm marking this as "Resolved". Hopefully you can upgrade to the latest version of AR, 1.7.3, at some point soon.