Expand or create a new structure test to test for use of ContextSource in SpecialPage constructor
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Umherirrender
	Dec 7 2021, 1:30 PM

Description

The use of SpecialPage::getContext or some other functions in the SpecialPage constructor leads to global state.

With https://gerrit.wikimedia.org/r/c/mediawiki/core/+/737791 I have expanded a structure test, but it fails on some extensions (T297020) and gets reverted.

How to reapply the patch set and verify that all extension tests still pass as tests in /structure/ folder are running on extensions/skins as well?

Throwing an exception for all global states in SpecialPage::getContext could impact also all extensions. There is no way on the CI to test such things. Needs to be verifiy on local runs against all extensions.

Related Objects

Mentioned In: T290706: Parser code for special page transclusion replaces main context
T297020: Wikibase gate-and-submit failing: “is not safe to call SpecialPage::getContext() (possible indirectly by other get*() functions)”
Mentioned Here: T297020: Wikibase gate-and-submit failing: “is not safe to call SpecialPage::getContext() (possible indirectly by other get*() functions)”

Event Timeline

Umherirrender created this task.Dec 7 2021, 1:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 7 2021, 1:30 PM

Umherirrender mentioned this in T297020: Wikibase gate-and-submit failing: “is not safe to call SpecialPage::getContext() (possible indirectly by other get*() functions)”.Dec 7 2021, 1:31 PM

Mainframe98 added a subscriber: Mainframe98.Dec 7 2021, 5:33 PM

Umherirrender mentioned this in T290706: Parser code for special page transclusion replaces main context.Dec 19 2021, 12:33 AM

Umherirrender removed a subscriber: Umherirrender.Mar 15 2022, 10:02 PM

Izno moved this task from To triage to SpecialPage system on the MediaWiki-Special-pages board.Apr 24 2022, 12:42 AM

Expand or create a new structure test to test for use of ContextSource in SpecialPage constructorOpen, Needs TriagePublicActions

Description

Related Objects

Event Timeline

Expand or create a new structure test to test for use of ContextSource in SpecialPage constructor
Open, Needs TriagePublic
Actions