Page MenuHomePhabricator
Create Task
Maniphest T297248

TypeError: Argument 1 passed to GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider::hasMinimumWidth() must be of the type integer, null given, called in /srv/mediawiki/php-1.38.0-wmf.12/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php on line 242
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Argument 1 passed to GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider::hasMinimumWidth() must be of the type integer, null given, called in /srv/mediawiki/php-1.38.0-wmf.12/extensions/Growt
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.12/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php(292)
#0 /srv/mediawiki/php-1.38.0-wmf.12/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php(242): GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider::hasMinimumWidth(NULL, integer)
#1 /srv/mediawiki/php-1.38.0-wmf.12/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php(167): GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider::processApiResponseData(Title, string, array, GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationMetadataProvider, array)
#2 /srv/mediawiki/php-1.38.0-wmf.12/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/CacheBackedImageRecommendationProvider.php(63): GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider->get(Title, GrowthExperiments\NewcomerTasks\TaskType\ImageRecommendationTaskType)
#3 /srv/mediawiki/php-1.38.0-wmf.12/includes/libs/objectcache/wancache/WANObjectCache.php(1689): GrowthExperiments\NewcomerTasks\AddImage\CacheBackedImageRecommendationProvider::GrowthExperiments\NewcomerTasks\AddImage\{closure}(boolean, integer, array, NULL, array)
#4 /srv/mediawiki/php-1.38.0-wmf.12/includes/libs/objectcache/wancache/WANObjectCache.php(1518): WANObjectCache->fetchOrRegenerate(string, integer, Closure, array, array)
#5 /srv/mediawiki/php-1.38.0-wmf.12/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/CacheBackedImageRecommendationProvider.php(68): WANObjectCache->getWithSetCallback(string, integer, Closure)
#6 /srv/mediawiki/php-1.38.0-wmf.12/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSetListener.php(47): GrowthExperiments\NewcomerTasks\AddImage\CacheBackedImageRecommendationProvider::getWithSetCallback(WANObjectCache, GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider, GrowthExperiments\NewcomerTasks\TaskType\ImageRecommendationTaskType, Title)
#7 /srv/mediawiki/php-1.38.0-wmf.12/includes/deferred/MWCallableUpdate.php(38): GrowthExperiments\NewcomerTasks\TaskSetListener->GrowthExperiments\NewcomerTasks\{closure}()
#8 /srv/mediawiki/php-1.38.0-wmf.12/includes/deferred/DeferredUpdates.php(507): MWCallableUpdate->doUpdate()
#9 /srv/mediawiki/php-1.38.0-wmf.12/includes/deferred/DeferredUpdates.php(392): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#10 /srv/mediawiki/php-1.38.0-wmf.12/includes/deferred/DeferredUpdates.php(221): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#11 /srv/mediawiki/php-1.38.0-wmf.12/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#12 /srv/mediawiki/php-1.38.0-wmf.12/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#13 /srv/mediawiki/php-1.38.0-wmf.12/includes/deferred/DeferredUpdates.php(242): DeferredUpdatesScope->processUpdates(integer, Closure)
#14 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(1106): DeferredUpdates::doUpdates()
#15 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(830): MediaWiki->restInPeace()
#16 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(579): MediaWiki->doPostOutputShutdown()
#17 /srv/mediawiki/php-1.38.0-wmf.12/index.php(53): MediaWiki->run()
#18 /srv/mediawiki/php-1.38.0-wmf.12/index.php(46): wfIndexMain()
#19 /srv/mediawiki/w/index.php(3): require(string)
#20 {main}
Notes

One hit seen so far during the wmf.12 train (T293953)

Details

Request URL
https://test.wikipedia.org/w/index.php?title=*&source=*&namespace=*
SubjectRepoBranchLines +/-
CacheDecorator: Use JSON serializationmediawiki/extensions/GrowthExperimentsmaster+60 -10
CacheDecorator: Bump cache versionmediawiki/extensions/GrowthExperimentswmf/1.38.0-wmf.12+1 -1
CacheDecorator: Bump cache versionmediawiki/extensions/GrowthExperimentsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

dancy created this task.Dec 7 2021, 10:37 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptDec 7 2021, 10:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
dancy updated the task description. (Show Details)Dec 7 2021, 10:39 PM
Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Dec 9 2021, 5:19 AM
Tgr moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
Tgr subscribed.Dec 9 2021, 6:20 AM

This is probably due to cache incompatibility: TaskSetListener calls CacheBackedImageRecommendationProvider::getWithSetCallback on each cached task; since they were cached on 1.38.0-wmf.9, there is no minimumImageSize field in the settings. This will break further task submission attempts as long as the users have a cached taskset (up to a week). We should probably change the cache version and backport.

gerritbot added a comment.Dec 9 2021, 6:46 AM

Change 745387 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] CacheDecorator: Bump cache version

https://gerrit.wikimedia.org/r/745387

gerritbot added a project: Patch-For-Review.Dec 9 2021, 6:46 AM
Tgr claimed this task.Dec 9 2021, 6:46 AM
Tgr moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Dec 9 2021, 8:46 AM

Change 745387 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] CacheDecorator: Bump cache version

https://gerrit.wikimedia.org/r/745387

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 9 2021, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 9 2021, 9:10 AM
gerritbot added a comment.Dec 9 2021, 9:14 AM

Change 745371 had a related patch set uploaded (by Kosta Harlan; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.12] CacheDecorator: Bump cache version

https://gerrit.wikimedia.org/r/745371

gerritbot added a project: Patch-For-Review.Dec 9 2021, 9:14 AM
Sgs subscribed.Dec 9 2021, 9:33 AM

My bad, I was unaware of this situation. @Tgr would it be useful to create some test for this so it doesn't happen again?

gerritbot added a comment.Dec 9 2021, 12:36 PM

Change 745371 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.12] CacheDecorator: Bump cache version

https://gerrit.wikimedia.org/r/745371

Stashbot added a comment.Dec 9 2021, 12:47 PM

Mentioned in SAL (#wikimedia-operations) [2021-12-09T12:47:22Z] <kharlan@deploy1002> Synchronized php-1.38.0-wmf.12/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/CacheDecorator.php: Backport: [[gerrit:745371|CacheDecorator: Bump cache version (T297248)]] (duration: 01m 05s)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.12; 2021-12-06); removed MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 9 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 9 2021, 1:10 PM
Tgr added a comment.Dec 10 2021, 3:31 AM
In T297248#7558760, @Sgs wrote:

My bad, I was unaware of this situation. @Tgr would it be useful to create some test for this so it doesn't happen again?

I don't think we have the infrastructure for testing issues arising from serialization and unserialization being done by different branches of code. IMO the most helpful thing would be avoiding serialization / unserialization of PHP objects. As long as hydration/dehydration happens via dedicated entry points it's much less likely that the objects end up in some unexpected state.

gerritbot added a comment.Dec 10 2021, 3:33 AM

Change 742594 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] [WIP] CacheDecorator: Use JSON serialization

https://gerrit.wikimedia.org/r/742594

gerritbot added a project: Patch-For-Review.Dec 10 2021, 3:33 AM
gerritbot added a comment.Dec 13 2021, 9:42 PM

Change 742594 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] CacheDecorator: Use JSON serialization

https://gerrit.wikimedia.org/r/742594

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.13; 2021-12-13); removed MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 13 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 13 2021, 10:10 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 15 2021, 9:00 AM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 15 2021, 7:43 PM
Etonkovidova closed this task as Resolved.Dec 17 2021, 12:43 AM
Etonkovidova subscribed.

Checked on wmf.13 - the error is not present.

Krinkle moved this task from Untriaged to Dec 2021 on the Wikimedia-production-error board.Jan 13 2022, 6:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL