[wmf.12- regression] Add image - rejected image cannot be submitted
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Dec 7 2021, 10:49 PM

Description

On a image recommendation article click 'No' in the image inspector to reject a suggested image.
"Why not?" popup can be left unchecked - click on "Submit".
On "Save your changes" overlay click on "Submit" again - the error message will be displayed: "Captions must be 5 characters or longer"

Note: the issue is present in betalabs too.

	Subject	Repo	Branch	Lines +/-
	Add an image: Only validate caption if the recommendation is accepted	mediawiki/extensions/GrowthExperiments	wmf/1.38.0-wmf.12	+1 -1
	Add an image: Only validate caption if the recommendation is accepted	mediawiki/extensions/GrowthExperiments	master	+1 -1

Mentioned Here: T296962: Add image - caption can be published blank by entering white spaces

Change 744893 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: Only validate caption if the recommendation is accepted

This regressed from T296962: Add image - caption can be published blank by entering white spaces . The issue is that the caption is being validated even when the recommendation is rejected.

Change 744896 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.12] Add an image: Only validate caption if the recommendation is accepted

Change 744893 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: Only validate caption if the recommendation is accepted

Change 744896 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.12] Add an image: Only validate caption if the recommendation is accepted

Checked after the fix was deployed on testwiki wmf.12 - the issue is fixed.