⚓ T297262 Add WikiAuthBot to translatewiki.net

Subject	Repo	Branch	Lines +/-
Add support URL for WikiAuthBot	translatewiki	master	+5 -0
WikiAuthBot: Fix regex boundary	translatewiki	master	+1 -1
Add WikiAuthBot	translatewiki	master	+29 -1

IVORK created this task.Dec 8 2021, 2:33 AM

Restricted Application added a project: User-RhinosF1. · View Herald TranscriptDec 8 2021, 2:33 AM

Restricted Application added subscribers: RhinosF1, Reception123, Aklapper. · View Herald Transcript

IVORK updated the task description. (Show Details)Dec 8 2021, 2:34 AM

Nikerabbit moved this task from Backlog to New projects for translation on the translatewiki.net board.Jan 4 2022, 9:00 AM

Translatewiki.net requires each language to have it's own file. That means we'd have a separate files: en.json, uk.json, fr.json etc. WikiAuthBot Discord bot currently has all the languages in a single file: /Wiki/responses.json which translatewiki cannot parse and read.

So en.json would have,

{
            "lang": "EN",
            "Welcome": "Welcome",
            "2auth": "! If you would like to authenticate (validate) your Wikimedia account, please type **.auth**",
            "Hello": "Hello",
            "pmoff": "You have private messages disabled",
            "pmoff2": ", please enable them by clicking the arrow next to GUILDNAME and selecting *Privacy Settings*. Then type **.auth** again.",
            "pmauth": "To authenticate to your Wikimedia account, please follow this link:",
            "Commands:": "Commands:",
            ....
}

Can this change be made?

RhinosF1 moved this task from Radar to Miraheze-Linked on the User-RhinosF1 board.Jan 7 2022, 11:12 PM

Restricted Application added a subscriber: Universal_Omega. · View Herald TranscriptJan 7 2022, 11:12 PM

Nikerabbit changed the task status from Open to Stalled.Jan 17 2022, 10:24 AM

Hi there @abi_, apologies for the delay, changes have been made as requested with the files now available within https://github.com/1VORK/WikiAuthBot/blob/master/Wiki/languages/.

In T297262#7687636, @IVORK wrote:

Hi there @abi_, apologies for the delay, changes have been made as requested with the files now available within https://github.com/1VORK/WikiAuthBot/blob/master/Wiki/languages/.

Thanks. I've updated the task description and added some concerns that I'd like to have address.

abi_ updated the task description. (Show Details)Feb 15 2022, 5:59 AM

abi_ updated the task description. (Show Details)Feb 15 2022, 6:34 AM

Universal_Omega unsubscribed.Feb 15 2022, 6:41 AM

Nikerabbit added a project: Unplanned-Sprint-Work.Feb 15 2022, 7:49 AM

Change 764113 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] Add WikiAuthBot

https://gerrit.wikimedia.org/r/764113

gerritbot added a project: Patch-For-Review.Feb 21 2022, 6:53 AM

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2022-January-March) board.Feb 21 2022, 7:12 AM

Change 764113 merged by jenkins-bot:

[translatewiki@master] Add WikiAuthBot

https://gerrit.wikimedia.org/r/764113

jenkins-bot mentioned this in rGTWN23f5ce65796d: Add WikiAuthBot.Feb 21 2022, 3:09 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 21 2022, 3:10 PM

@IVORK - While performing the import we noticed that the translation files contain English strings (Eg: https://github.com/1VORK/WikiAuthBot/blob/master/Wiki/languages/nl.json). Is this to handle fallback where if something is not translated, then the English string would be displayed?

Having English messages in the translation files does not suit translatewiki's workflow as filtering of non translated strings would break. Additionally if translation is made for a new language, translatewiki will not copy all the English strings into that new translation file.

We've reverted the patch that was adding the project to translatewiki until this is addressed.

abi_ changed the task status from Open to In Progress.Feb 22 2022, 1:29 PM

abi_ moved this task from In Review to In Progress on the Language-Team (Language-2022-January-March) board.

abi_ changed the task status from In Progress to Stalled.Feb 23 2022, 11:05 AM

Nikerabbit moved this task from In Progress to Blocked on the Language-Team (Language-2022-January-March) board.Feb 24 2022, 1:10 PM

Changes made as requested @abi_

In T297262#7805755, @IVORK wrote:

Changes made as requested @abi_

Thanks @IVORK. Looking at this commit: https://github.com/1VORK/WikiAuthBot/commit/2abab5abeea238bd866860019d148aa27eb4c779 - I notice that the values are removed but the keys are left. We expect keys with empty content to be removed as well.

In T297262#7809647, @abi_ wrote:

In T297262#7805755, @IVORK wrote:

Changes made as requested @abi_

Thanks @IVORK. Looking at this commit: https://github.com/1VORK/WikiAuthBot/commit/2abab5abeea238bd866860019d148aa27eb4c779 - I notice that the values are removed but the keys are left. We expect keys with empty content to be removed as well.