Page MenuHomePhabricator

Box about automatic topic subscriptions didn't clean up properly
Open, Needs TriagePublic


  1. Post a ==new discussion== (for the first time).
  2. See the box that says you've been automatically subscribed.
  3. Click "Okay, I've got it" to dismiss the box.
  4. See the shadow of the box still on the page.

Screen Shot 2021-12-07 at 6.45.20 PM.png (660×1 px, 109 KB)

Event Timeline

matmarex added a subscriber: matmarex.

Reminds me of T226872… I think I might have accidentally overwritten the workaround for that bug by adding the little animation shown when the automatic topic subscriptions appears/disappears.

Change 745557 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Work around a Safari bug causing shadows to remain when the popup is removed

@Whatamidoing-WMF I don't have a Mac to test on Safari, can you check for me that the patch fixes the problem? I've prepared demo wikis:

I couldn't reproduce on Safari 14.1. Someone else will have to test.

I've cleared the user preference that hides the popup, if someone needs to test multiple times, clear the preference after each test by putting the following in the console:
(new mw.Api()).saveOption( 'discussiontools-seenautotopicsubpopup', '0' );

I'm afraid that I also can't reproduce the shadows lingering, on Safari 15.2.

However, I do notice that the change does make the shadows on the popup much more reliably-present. Pre-patch the shadows don't appear for a second or two after the popup appears, whereas after-patch they're immediate.

Change 745557 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Work around a Safari bug causing shadows to remain when the popup is removed

matmarex edited projects, added Skipped QA; removed Patch-For-Review.

Skipping QA on the assumption that no one but @Whatamidoing-WMF can reproduce this :)

It works!

The issue was reproducible today in the older PatchDemo instance, and it is fixed in the newer one.

I tested this in Safari Version 15.2 (17612. on macOS Monterey 12.1 (21C52).